Tema mobile GolemWiki
Go to file
Piotr Miazga 9d90df7b0b SkinMinerva testGetContextSpecificModule test might use undefined title
Test scenario for getContextSpecificModules() mocks only Skin->getTitle()
behavior, but while executing isAllowedPageAction() Skin will create a
UserPageHelper with default RequestContext. As RequestContext is not mocked,
$context->getTitle() will return undefined what could lead to tests crash

Changes:
 - instead of mocking SkinMinerva::getTitle() pass test context with injected
title. Other tests will work properly as MediaWikiTestCase::tearDown() always
restes RequestContext to default

Bug: T170624
Change-Id: I872fddf8d9c52a6875bb6c69a12407a8125fba4c
2017-07-17 21:40:34 +02:00
dev-scripts Add tooling for svg size checking 2017-07-14 11:07:08 -07:00
i18n Add missing Minerva skin description message key 2017-07-13 14:03:00 -07:00
includes Give MinervaNeue control of the minerva skin name 2017-07-12 14:49:52 -07:00
minerva.less Minerva is its own skin 2017-07-12 08:12:40 -07:00
resources Minerva is its own skin 2017-07-12 08:12:40 -07:00
scripts Fixes to migrate script with regards to i18n 2017-07-12 04:23:38 +00:00
skinStyles Minerva is its own skin 2017-07-12 08:12:40 -07:00
tests SkinMinerva testGetContextSpecificModule test might use undefined title 2017-07-17 21:40:34 +02:00
.eslintrc.json Add scaffolding for skin 2017-06-01 10:17:24 -07:00
.gitignore Add .gitignore file 2017-07-11 21:14:48 -07:00
.gitreview Use track=1 instead of defaultbranch=master in .gitreview 2016-10-24 17:30:30 -07:00
.rubocop.yml Port browser tests from MobileFrontend to Minerva 2017-07-11 14:11:03 -07:00
.stylelintrc Add scaffolding for skin 2017-06-01 10:17:24 -07:00
CODE_OF_CONDUCT.md Add CODE_OF_CONDUCT.md 2017-06-07 13:47:45 +04:30
Gemfile Placeholder to avoid failing browser tests 2017-06-23 16:26:13 -07:00
Gemfile.lock Placeholder to avoid failing browser tests 2017-06-23 16:26:13 -07:00
Gruntfile.js Add scaffolding for skin 2017-06-01 10:17:24 -07:00
MinervaNeue.php Add scaffolding for skin 2017-06-01 10:17:24 -07:00
Rakefile Port browser tests from MobileFrontend to Minerva 2017-07-11 14:11:03 -07:00
package.json Add tooling for svg size checking 2017-07-14 11:07:08 -07:00
skin.json minerva-neue valid skin name should not be necessary 2017-07-13 01:11:44 +00:00