golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,311 Commits 2 Branches 0 Tags 3.1 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Ed Sanders eeebb86270 Avoid deprecated View.$ 
Replace with View.$el.find.

Bug: T216264
Change-Id: I78045c410c168bf458ab8f5537036711fc5b577c
 2019-02-15 19:04:11 +00:00
Stephen Niedzielski 5593b23aa8 Hygiene: replace mobile.startup/paths with props 
Replace all occurrences of `M.require( 'mobile.startup/pathToModule' )`
with `M.require( 'mobile.startup' ).pathToModule`. Where multiple
requires existed, add an intermediate variable,
`var mobile = M.require( 'mobile.startup' )`, and dot off that.

This changes improves the consistency of MinervaNeue which currently
contains a mix of require styles and eliminates any deprecated requires.

Bug: T208915
Change-Id: If14f280672d914d07275197100b12421bb217b67
 2019-02-07 14:55:04 -07:00
jdlrobson d29eca2bc8 pageIssuesOverlay is a factory function that returns an Overlay 
This experiments with making PageIssuesOverlay an Overlay with
various options.

The appending of children is a little messy and points at a need
to standardise this some way
(see https://phabricator.wikimedia.org/T209647)

TODO:
* Remove the iconString property on PageIssueSummary which is no longer
needed

Bug: T209647
Change-Id: Iadd798a820dca6bbb31edc9a8570b6db7aac237a
 2019-01-03 08:31:39 -08:00