Commit Graph

15 Commits

Author SHA1 Message Date
Bartosz Dziewoński 5e7b3994fd Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles
We need to load these only when VisualEditor is loaded. This is
the best way to ensure that. They have been haphazardly placed
in different files.

The goal of this change is to move content styling for Minerva out of
mobile.editor.ve/minerva.less, and thus to be able to move this file
to mediawiki/extensions/MobileFrontend (T202978). But I spotted the
other places while working on that.

Moved as-is:
* skins.minerva.content.styles/links.less
* mobile.editor.ve/minerva.less

No longer needed:
* skins.minerva.content.styles/text.less
  Parsoid now uses <sup> tags for references rather than <span>,
  so the existing rules for <sup> tags are enough. See T45094,
  <https://www.mediawiki.org/wiki/Specs/HTML/1.6.0/Extensions/Cite>.

Was never needed:
* skins.minerva.content.styles/thumbnails.less
  The styles from the core module 'mediawiki.skinning.content.parsoid'
  are never loaded, so we don't need to override them.

Bug: T202978
Change-Id: I45e1cb89b65a41a29d2b1a361a79199745ccec14
2018-09-17 21:55:32 +00:00
Bartosz Dziewoński 73d724a72f mobile.editor.ve: Simplify left/right border of toolbar on >1000px screens
There should be no visual changes in this commit.

The goal of this change is to stop using variables from
minerva.variables, and thus to be able to move this file
to mediawiki/extensions/MobileFrontend (T202978).

Bug: T202978
Change-Id: Ib4b3206f724c3e6f089e626b704dc8ff790a76ae
2018-09-17 21:55:18 +00:00
Bartosz Dziewoński ac549d9c70 mobile.editor.ve: Simplify margin/padding for debug bar
Requires Ia13f758a6870be2e6c89fd11f2ee3544ac61a1d7 in
mediawiki/extensions/VisualEditor to be merged at the same time.
There should be no visual change if both are merged.

The goal of this change is to stop using variables from
minerva.variables, and thus to be able to move this file
to mediawiki/extensions/MobileFrontend (T202978).

Bug: T202978
Change-Id: I28278449512ed1e5e8c4ac6ae390334a26d1bad6
2018-09-17 22:28:07 +02:00
Ed Sanders 04a2b27d7f build: Update linters
This exposes two broken tests:

* #setCount (Eastern Arabic numerals)
* clicking on the product of createBanner() should trigger a custom event

that were previously passing due to buggy assertions.

Change-Id: If18ad1ff9363fff65d3e347c01ce4bc0669b2a0e
2018-09-11 13:42:11 -07:00
jenkins-bot 4cc3bfa6ae Merge "Remove webkit-transform hack to fix stacking" 2018-08-29 00:50:10 +00:00
jenkins-bot b104d5ca1b Merge "Remove duplicate heading styles" 2018-08-29 00:50:05 +00:00
jenkins-bot 6f9a81861a Merge "Fix width of headings in mobile editor" 2018-08-29 00:49:50 +00:00
Ed Sanders a00d90ee6c Remove duplicate heading styles
These styles have since been moved such that they
apply in read and edit mode.

Change-Id: I2dc6fd69604d08dafeaf8cf17b3f048caa16496e
2018-08-28 15:06:12 +01:00
Ed Sanders 591370c35f Fix width of headings in mobile editor
This also fixes CE issues arising from using display:table.

Bug: T202991
Change-Id: I39ab5d4ed9a2ace7593dd3078382f522b75f5576
2018-08-28 15:05:05 +01:00
Ed Sanders d3eb0d7c30 Remove z-index:6 hack from VE mobile overlays
MobileFrontend no longer uses z-index:5 for the toobar,
the default z-index:2 is sufficient for the overlays to
appear on top.

Lowering this value allows toolbars to appears on top of
local overlays, such as deactivated selections.

Bug: T202990
Change-Id: I55ff6971249427c12c090018fcd4d4e5d0ec85d1
2018-08-28 14:24:59 +01:00
Ed Sanders 9ed6b24f69 Remove webkit-transform hack to fix stacking
Bug: T202980
Change-Id: Iea8a3b9cf6c837f04610310e5b495d77ef60b219
2018-08-28 13:02:47 +01:00
Ed Sanders 34a1ea3568 Slightly reduce toolbar height when using VE
Bug: T190596
Depends-On: Ieb292ed14e0b9205d15254667e97613fbf339260
Change-Id: Id1dbc692d8528fb1500545eb0e992d2f8ebfbd9f
2018-08-14 05:17:18 +00:00
Volker E 8f0e102211 Remove special `font-size` treatment of VE overlay
Reverting of I6b8a031c2d78785604070ff5fc1c7242bbbc080f as first step
of resolving issues and complex inheritance of VE mobile tools CSS.

Bug: T195791
Change-Id: Ief66c0d3565d3b67399e5aa2a749035a9a4b47bc
2018-05-31 17:36:58 +02:00
Timo Tijhof 64134bd8a6 Remove minerva.less from global import path
Use local imports instead given all relevant files are within the
same repository, and don't vary by configuraion.

Bug: T140807
Depends-On: If3edac9a35b346af0320c12f70c0d978a6346201
Change-Id: Ife3cc345a63aff452e93accbe0a593fbaa358732
2018-05-29 12:19:00 +00:00
Timo Tijhof 91a3adacb7 Move remaining Minerva skinStyles from MobileFrontend
To be removed in MobileFrontend by If3edac9a35b346a.

Bug: T140807
Change-Id: Ifb073d1e67602b80e0e9b45f338806f5b9cb675b
2018-05-29 09:30:48 +00:00