Commit Graph

1512 Commits

Author SHA1 Message Date
Translation updater bot
fb7f27ac64 Localisation updates from https://translatewiki.net.
Change-Id: Ieba429759aab16206631a58d336f37939492cd7f
2017-11-15 21:56:39 +01:00
Volker E
8497d6d259 Unify SVG markup
Align SVG markup across Foundation products by:
- unifying XML declaration,
- adding `width` and `height` attributes where missing,
- removing all unnecessary `g` group elements where applicable,
- putting attributes in order,
- removing unnecessary ids and
- unifying whitespace.

Bug: T178867
Change-Id: I6860c9259553e0e41f7656f9e98534db8e02bbc2
2017-11-14 21:44:40 +00:00
Ed Sanders
8dd2544c0e Copy external link numbering from content.parsoid.less
Change-Id: I308d06ada35e63d81db8d034717f650d54aafc78
2017-11-13 19:20:29 +00:00
jenkins-bot
4d17797186 Merge "Do not center align h2s in footer" 2017-11-13 19:04:14 +00:00
jenkins-bot
5a4b645cd7 Merge "Restrict footer styles to skin footer" 2017-11-13 19:04:14 +00:00
jdlrobson
6df96ca768 Do not center align h2s in footer
In Id9b0e955d6e2a113f91484c7ee6bbc9275e3a2ec the css selector
was weakened and started impacting the footer as well.

This restores the old behaviour.

Bug: T180375
Change-Id: Ibfff6e249a3249ae2ee97d31fd50d2f5272a25ae
2017-11-13 10:49:21 -08:00
jdlrobson
14ddb0a742 Restrict footer styles to skin footer
The Popups extension uses a footer element so these rules clash with
that and probably other extensions.

To avoid this restrict the element to the skin.

Change-Id: Iac3aa8e600969a0feb0abeee745cd26592a594fd
2017-11-10 20:06:03 -08:00
jenkins-bot
854cd3e851 Merge "Do not try to add edit links to the HTML in contexts without a Title" 2017-11-10 02:15:45 +00:00
jdlrobson
e422eb9a81 Do not try to add edit links to the HTML in contexts without a Title
Title may be null when accessed via this->getTitle()
If this is the case we should assume the skin is being used by someone
who is not a reader and in these circumstances, not try to render any
page actions.

Bug: T179833
Change-Id: Ia47fd9b059101bf22b5d31be7df3a332b35d6b24
2017-11-09 21:23:48 +00:00
jdlrobson
7697c262db Limit download button to Google Chrome
As discussed on ticket the download button only appears
to work on Google Chrome on mobile browsers.

Bug: T179529
Bug: T179914
Change-Id: I8bbda8d5a8aa42dd23773fea424c1a70e31d6f85
2017-11-09 21:11:02 +00:00
jenkins-bot
9fa40f81d8 Merge "Move class_alias out of skin initialization" 2017-11-08 06:46:20 +00:00
Kunal Mehta
74b3faf580 Move class_alias out of skin initialization
Use the standard way of doing it by adding an autoloader entry, and putting
the class_alias() call into the same file as the class.

Change-Id: I93e19ebcf3dd7d9815623de5e24861949fd0269a
2017-11-08 00:20:00 +00:00
jdlrobson
256606f672 Style kbd and samp elements as monospace
Bug: T175709
Change-Id: I0c11fbfe3fab0a0bc9fcea429970861b10643182
2017-11-07 22:59:09 +00:00
Translation updater bot
8a616daf3b Localisation updates from https://translatewiki.net.
Change-Id: I3e37dc60e58222c0655f4bc525494c852b20da9f
2017-11-07 22:05:36 +01:00
Volker E
29026b75bb Align icon variants with WikimediaUI color palette
Follow-up to I067973dca580eddc09b770362183d7a5b1634b7c

Bug: T146799
Change-Id: Idd02de3883c8c5a971dff657d002f4c9e09c88eb
2017-11-06 21:25:30 +00:00
Translation updater bot
2a0fcaec38 Localisation updates from https://translatewiki.net.
Change-Id: Idee87617465ebc01d62db34e7e1f790f741bdd81
2017-11-06 22:22:41 +01:00
Translation updater bot
25ed84a23a Localisation updates from https://translatewiki.net.
Change-Id: I3e517502d94533dcc07b820fb3a256eac4d9c7c3
2017-11-05 21:56:53 +01:00
Translation updater bot
63a9ec3564 Localisation updates from https://translatewiki.net.
Change-Id: Ic0de0ab78b243e15e45bc11723c71343d79000e6
2017-11-04 22:07:13 +01:00
Translation updater bot
35d5879ef3 Localisation updates from https://translatewiki.net.
Change-Id: Ib33054251fac22f2d74b26aaaf2872522a205172
2017-11-03 21:58:19 +01:00
jenkins-bot
9cb8130a0a Merge "Switch to outside list style" 2017-11-03 20:56:33 +00:00
Translation updater bot
732e3ee002 Localisation updates from https://translatewiki.net.
Change-Id: I5068d47ea21614f51ed1b8834c223b5c55808837
2017-11-02 22:19:13 +01:00
jdlrobson
b843fb2312 Switch to outside list style
Bug: T150377
Change-Id: Ic5b90ab8e369d113f0f46c8c5d7b7a63951bcbd4
2017-11-02 10:56:51 -07:00
Umherirrender
7a95a43104 build: Always exclude node_modules
Change-Id: I8f055032f1a076445c18ac96d90017a44d6d9077
2017-11-02 17:53:18 +01:00
jdlrobson
10431c4ed1 Hygiene: Move css rule to Minerva
In preparation for "Adopt new special page template for special pages"
(T169379) move the text alignment rule to Minerva.

Change-Id: I5118a58bcb948c93e511587b8a3f29246b33acd7
2017-11-01 17:06:03 -07:00
Translation updater bot
0d4c7bbaec Localisation updates from https://translatewiki.net.
Change-Id: Ied6584b5a3ed7942aa53690d8c327892303c0e33
2017-11-01 22:06:10 +01:00
jdlrobson
a7ab80335a Reveal edit icon and style top level headings on desktop Minerva
Bug: T179356
Change-Id: I414040658eeb8a24d41f6496dd634ef47e3e9952
2017-11-01 18:54:44 +00:00
jdlrobson
dfabc67d95 Hygiene: Remove dead call to addModuleStyles
This is adding an empty array and not necessary

Change-Id: I232dd9b0fe7343a6531582ad66a62d3babe275e3
2017-11-01 11:20:17 -07:00
James D. Forrester
c87cbc7474 build: Organise Gruntfile.js more consistently
This also adds linting for skinStyles, with a few fixes to make these pass.

Change-Id: Id26b0bad21850d985eaaceda24fa50ad6f886458
2017-10-31 14:41:25 -07:00
Translation updater bot
dec165bf37 Localisation updates from https://translatewiki.net.
Change-Id: I709cc4f913507d679dc3bcdb45db368d3a8fc860
2017-10-31 21:58:41 +01:00
jenkins-bot
326ff8ec78 Merge "Hide table of contents temporarily on Minerva desktop" 2017-10-31 01:59:40 +00:00
jdlrobson
006dfaaa12 Hide table of contents temporarily on Minerva desktop
Currently appears unstyled, so in lieu of some styles it would be
better to hide that for the time being and revisit later.

Change-Id: If0f4f02868b1344746affcec5116c325c612d145
2017-10-30 18:11:32 -07:00
jdlrobson
58729578ae BetaOptin now managed by MobileFrontend
Depends-On: I83dc2165081332453cd6fc586ae7a3ba04bd3416
Change-Id: I11200f0ff90b359e363ea7a95bf4f3b9e92a67b4
2017-10-30 17:23:41 -07:00
James D. Forrester
227cd1d071 build: Bump run-time dependencies to latest, pin
jsdoc    3.4.2  →  3.5.5
 svgo   >=0.4.4  →  0.7.2

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695c
2017-10-30 23:55:26 +00:00
Translation updater bot
af20b6670e Localisation updates from https://translatewiki.net.
Change-Id: I7f5675ef6aa0a851580d809b2666eb01168f768e
2017-10-30 22:07:06 +01:00
jdlrobson
d3318a9f85 Remove MobileFrontend's font changing code from Minerva
Fontchanger code now runs on all skins under the `mobile` target.
All the code will now live in MobileFrontend meaning developers
can operate inside one code base.

Depends-On: I857cfe2d9be9fe49c04c860bc234384c787239b2
Change-Id: I2759455cb6d7ddf13798e94452cb74baf502bafe
2017-10-30 19:11:16 +00:00
jdlrobson
5cb46fe9d2 Hygiene: Minerva owns PointerOverlay
The only usage is inside Minerva so we will move this module here.

Change-Id: If6859f0c8f855c6b116b254c58a6814f54b7c36d
2017-10-30 18:00:02 +00:00
Translation updater bot
8e718f258b Localisation updates from https://translatewiki.net.
Change-Id: Ibbe3195b1ae2bcfeffbf42395d286f49b2a4f31a
2017-10-29 21:58:26 +01:00
Translation updater bot
44708b0d26 Localisation updates from https://translatewiki.net.
Change-Id: I849219295a8fd69e5e4306b65abb6e4d3f0f9058
2017-10-28 21:59:06 +02:00
Translation updater bot
045044b408 Localisation updates from https://translatewiki.net.
Change-Id: I1a267c5ad4fac7bd339a7e87a88e6003cf29a8b8
2017-10-27 21:56:39 +02:00
James D. Forrester
d5b4294386 build: Bump various devDependencies to latest, pin consistently
grunt                      ^1.0.1  →  1.0.1
 grunt-banana-checker       ^0.5.0  →  0.6.0
 grunt-contrib-watch        ^1.0.0  →  1.0.0
 grunt-eslint               20.0.0  → 20.1.0
 grunt-jsonlint             ^1.1.0  →  1.1.0
 grunt-notify               ^0.4.5  →  0.4.5

Change-Id: I2884c8daed3fe0e0d05c746ec6319956b742695a
2017-10-26 15:48:59 -07:00
jenkins-bot
accb0c6609 Merge "Minerva owns BacktoTopOverlay" 2017-10-26 20:40:18 +00:00
jdlrobson
038103299a Minerva owns BacktoTopOverlay
Not used in MobileFrontend so it is moved here from that repo.
t r
Change-Id: I97e6010026daf4c6610bcfbedf140fb2a45b1130
2017-10-26 16:34:16 -04:00
jdlrobson
12b49a70ad Notification icon should not show NaN for persian Wikipedia
Bug: T172755
Change-Id: I2884c8daed3fe0e0d05c746ec6319956b7426957
2017-10-26 20:27:12 +00:00
Translation updater bot
8a82f30dab Localisation updates from https://translatewiki.net.
Change-Id: Ic02a1cbb91ccdfdc10baa51a2b7491ab0c7c86ba
2017-10-26 21:57:18 +02:00
Translation updater bot
67724d988d Localisation updates from https://translatewiki.net.
Change-Id: I914bb8ba5edff15a82b76ee932136927daf2d007
2017-10-25 22:09:10 +02:00
Translation updater bot
9376aab9d2 Localisation updates from https://translatewiki.net.
Change-Id: I6b7670abb71bae893a63b5d45e65607bbb5694bd
2017-10-24 22:24:26 +02:00
jenkins-bot
c1bfaf55c6 Merge "Disable print button on iOS" 2017-10-23 20:35:14 +00:00
Translation updater bot
c86b87b3db Localisation updates from https://translatewiki.net.
Change-Id: I061466bdf2640d23bc9c2f41f5c36aec6c61da7b
2017-10-23 22:26:42 +02:00
jdlrobson
571895b754 Disable print button on iOS
As documented on the ticket, iOS does not provide PDF functionality
via print.

iOS 11 provides PDF generation but the resulting PDF is unreadable for
our content and missing styles (see T177215#3700576) and we do not know
of any way to invoke that just yet.

Bug: T177215
Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
2017-10-23 16:06:25 -04:00
jdlrobson
45a1b3b423 Add feature flagged DownloadIcon
Shortcut for print. Disabled by default and controlled by
wgMinervaDownloadIcon

Note that with lazy images enabled, images will not appear
in the printed article. This can be easily addressed inside
the onClick function in a later patchset with a few modifications
to the Skin class.

Currently the flag when enabled will show on all browsers. There
are some open questions on the ticket about how we want to limit
the feature. This shouldn't block review or merging.

Bug: T177215
Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-23 18:12:20 +00:00