golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 

The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.OneClassPerFile.MultipleFound

The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.SpacingAfterParamType
* MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage

Change-Id: I0689ff20133a2a23d6389aa50487349c6ed3797b
This commit is contained in:
libraryupgrader 2017-09-01 05:01:10 +00:00
parent c323c6858a
commit f86c148866
5 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
composer.json
View File

@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"mediawiki/mediawiki-codesniffer": "0.10.1",
"mediawiki/mediawiki-codesniffer": "0.12.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

8
includes/skins/MenuBuilder.php
View File

@ -39,7 +39,7 @@ class MenuBuilder {
* Insert an entry into the menu.
*
* @param string $name A unique name identifying the menu entry
* @param bool [$isJSOnly] Whether the menu entry works without JS
* @param bool [ $isJSOnly] Whether the menu entry works without JS
* @throws DomainException When the entry already exists
* @return MenuEntry
*/
@ -77,7 +77,7 @@ class MenuBuilder {
* @param string $targetName The name of the existing entry to insert
* the new entry after
* @param string $name The name of the new entry
* @param bool [$isJSOnly] Whether the entry works without JS
* @param bool [ $isJSOnly] Whether the entry works without JS
* @throws DomainException When the existing entry doesn't exist
* @return MenuEntry
*/
@ -148,9 +148,9 @@ class MenuEntry {
*
* @param string $label
* @param string $url
* @param string [$className] Any additional CSS classes that should added to the output,
* @param string [ $className] Any additional CSS classes that should added to the output,
* separated by spaces
* @param array [$attrs] Additional data that can be associated with the component
* @param array [ $attrs] Additional data that can be associated with the component
*
* @return MenuEntry
*/

4
includes/skins/MinervaTemplate.php
View File

@ -213,7 +213,7 @@ class MinervaTemplate extends BaseTemplate {
$html .= $postHeadingHtml;
$html .= $data['subtitle'];
$html .= $internalBanner;
$html .= '</div>';
$html .= '</div>';
}
return $html;
}
@ -242,7 +242,7 @@ class MinervaTemplate extends BaseTemplate {
/**
* Gets the main menu only on Special:MobileMenu.
* On other pages the menu is rendered via JS.
* @param array [$data] Data used to build the page
* @param array [ $data] Data used to build the page
* @return string
*/
protected function getMainMenuHtml( $data ) {

6
includes/skins/SkinMinerva.php
View File

@ -48,7 +48,7 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin {
// If there's a custom site logo, use that instead of text
if ( isset( $customLogos['copyright'] ) ) {
$attributes = [
$attributes = [
'src' => $customLogos['copyright'],
'alt' => $footerSitename,
];
@ -231,7 +231,7 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin {
$message = $this->msg( 'mobile-frontend-editor-edit' )->inLanguage( $lang )->text();
$html = Html::openElement( 'span' );
$html .= Html::element( 'a', [
'href' => $this->getTitle()->getLocalUrl( [ 'action' => 'edit', 'section' => $section ] ),
'href' => $this->getTitle()->getLocalUrl( [ 'action' => 'edit', 'section' => $section ] ),
'title' => $this->msg( 'editsectionhint', $tooltip )->inLanguage( $lang )->text(),
'data-section' => $section,
// Note visibility of the edit section link button is controlled by .edit-page in ui.less so
@ -882,7 +882,7 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin {
'title' => $this->msg( 'mobile-frontend-main-menu-button-tooltip' ),
'href' => $url,
'class' => MobileUI::iconClass( 'mainmenu', 'element', 'main-menu-button' ),
'id'=> 'mw-mf-main-menu-button',
'id' => 'mw-mf-main-menu-button',
], $this->msg( 'mobile-frontend-main-menu-button-tooltip' ) )
);
}

6
phpcs.xml
View File

@ -3,12 +3,12 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName"/>
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage"/>
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag"/>
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment"/>
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"/>
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
<exclude name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch"/>
<exclude name="MediaWiki.Commenting.FunctionComment.SpacingAfterParamType"/>
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected"/>
<exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn"/>
</rule>