golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Simplify onResourceLoaderGetLessVars hook 

* Get ConfigFactory via its accessor, not getService()
* Avoid array_merge, use simpler syntax
* Don't use string interpolation when one variable is the entire string

Change-Id: Ic4c138fb3b83e6e9c6ff9a001dd39e03ca5029b1
This commit is contained in:
Kunal Mehta 2017-07-17 13:58:14 -07:00 committed by Jdlrobson
parent 7536ca089a
commit f7509adfbb
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
includes/Minerva.hooks.php
View File

@ -23,14 +23,10 @@ class MinervaHooks {
* @param array &$lessVars Variables already added
*/
public static function onResourceLoaderGetLessVars( &$lessVars ) {
$config = MediaWikiServices::getInstance()->getService( 'ConfigFactory' )
$config = MediaWikiServices::getInstance()->getConfigFactory()
->makeConfig( 'minerva' );
$lessVars = array_merge( $lessVars,
[
'wgMinervaApplyKnownTemplateHacks' => "{$config->get( 'MinervaApplyKnownTemplateHacks' )}",
]
);
$lessVars['wgMinervaApplyKnownTemplateHacks'] = $config->get( 'MinervaApplyKnownTemplateHacks' );
}
/**