From f2639e7a731e58332866597743a375192f73a90e Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Tue, 13 Nov 2018 16:49:24 -0800 Subject: [PATCH] QA: Don't check when_visible twice Instead check the element is in the DOM before testing its visibility. This might help T208808 but it's a stab in the dark. Change-Id: If7ccf5f2f03073c247de7fa497b3a6e31b570918 --- tests/browser/features/step_definitions/common_article_steps.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/browser/features/step_definitions/common_article_steps.rb b/tests/browser/features/step_definitions/common_article_steps.rb index d2296a2..5f1fa5c 100644 --- a/tests/browser/features/step_definitions/common_article_steps.rb +++ b/tests/browser/features/step_definitions/common_article_steps.rb @@ -32,7 +32,7 @@ Then(/^I should see a toast notification$/) do # Minerva loads mediawiki.notify at startup which defers the loading of this module # We must wait until the lazy loading has happened before checking for the toast (T170890) page.wait_until_rl_module_ready('mediawiki.notification') - expect(page.notification_area_element.when_visible).to be_visible + expect(page.notification_area_element.when_present).to be_visible end end