From b0384c431408f33203bf9903cedc0b235624796f Mon Sep 17 00:00:00 2001 From: Eddie Greiner-Petter Date: Sun, 30 Jul 2017 19:45:20 +0200 Subject: [PATCH] Show title on the page named '0' The string '0' evals to false in the if( $pageTitle ) condition, hence the title was not shown for the page named '0'. Bug: T163084 Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464 --- includes/skins/SkinMinerva.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 83af2fc..31cedd0 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -797,7 +797,8 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin { $heading = $this->getUserPageHelper()->getPageUser()->getName(); } else { $pageTitle = $this->getOutput()->getPageTitle(); - if ( $pageTitle ) { + // Loose comparison with '!=' is intentional, to catch null and false too, but not '0' + if ( $pageTitle != '' ) { $heading = $pageTitle; } }