From a6ba0f2c77954b50d37ec5f09271dae2d3a1c2a4 Mon Sep 17 00:00:00 2001
From: Stephen Niedzielski <stephen@niedzielski.com>
Date: Fri, 3 Aug 2018 15:29:24 -0500
Subject: [PATCH] Fix: page issue icon type determination

The page issuer parser works with plain old Elements, not jQuery. Pass
in the expected type.

This addresses problems with the icon display for ambox templates relating
to balance (see https://phabricator.wikimedia.org/T191528#4465069)

Bug: T191528
Change-Id: Ie4a34087f9f1700342cc54a50cd3272fc9ea34ee
---
 resources/skins.minerva.scripts/cleanuptemplates.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/resources/skins.minerva.scripts/cleanuptemplates.js b/resources/skins.minerva.scripts/cleanuptemplates.js
index ae465b0..1fdaa08 100644
--- a/resources/skins.minerva.scripts/cleanuptemplates.js
+++ b/resources/skins.minerva.scripts/cleanuptemplates.js
@@ -119,13 +119,13 @@
 		// store it for late
 		allIssues[section] = issues;
 
-		if ( inline ) {
+		if ( $metadata.length && inline ) {
 			severity = pageIssueParser.maxSeverity(
 				issues.map( function ( issue ) { return issue.pageIssue; } )
 			);
 			new Icon( {
 				glyphPrefix: 'minerva',
-				name: pageIssueParser.iconName( $metadata, severity )
+				name: pageIssueParser.iconName( $metadata.get( 0 ), severity )
 			} ).prependTo( $metadata.find( '.mbox-text' ) );
 			$learnMore = $( '<span>' )
 				.addClass( 'ambox-learn-more' )