Remove obsolete aliases from closures

Bug: T208951
Change-Id: I7cd5ab010596d964fc0896ed250f40d5b6344f6e

.eslintrc.json

@@ -2,12 +2,12 @@
 	"root": true,
 	"extends": "wikimedia",
 	"env": {
-		"browser": true,
+		"browser": true
-		"jquery": true
 	},
 	"globals": {
 		"OO": false,
 		"mw": false,
+		"$": false,
 		"Hogan": false,
 		"require": false
 	},

resources/skins.minerva.mainMenu/MainMenu.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var browser = M.require( 'mobile.startup/Browser' ).getSingleton(),
 		View = M.require( 'mobile.startup/View' );
 
@@ -130,4 +130,4 @@
 
 	M.define( 'skins.minerva.mainMenu/MainMenu', MainMenu );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.notifications/init.js

@@ -2,7 +2,7 @@
  * This code loads the necessary modules for the notifications overlay, not to be confused
  * with the Toast notifications defined by common/toast.js.
  */
-( function ( M, $ ) {
+( function ( M ) {
 	var mainMenu = M.require( 'skins.minerva.scripts.top/mainMenu' ),
 		router = require( 'mediawiki.router' ),
 		NotificationBadge = M.require( 'skins.minerva.notifications/NotificationBadge' ),
@@ -78,4 +78,4 @@
 		} );
 	} );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.options/BackToTopOverlay.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 
 	var View = M.require( 'mobile.startup/View' );
 
@@ -49,4 +49,4 @@
 
 	M.define( 'skins.minerva.options/BackToTopOverlay', BackToTopOverlay );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.options/backtotop.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var BackToTopOverlay = M.require( 'skins.minerva.options/BackToTopOverlay' ),
 		backtotop = new BackToTopOverlay(),
 		features = mw.config.get( 'wgMinervaFeatures', {} ),
@@ -19,4 +19,4 @@
 			backtotop.hide();
 		}
 	} );
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.options/categories.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 
 	var loader = M.require( 'mobile.startup/rlModuleLoader' ),
 		features = mw.config.get( 'wgMinervaFeatures', {} ),
@@ -51,4 +51,4 @@
 
 	$( initButton );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.scripts.top/init.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var MainMenu = M.require( 'skins.minerva.mainMenu/MainMenu' ),
 		mainMenu = createMainMenu();
 
@@ -29,4 +29,4 @@
 	} );
 
 	M.define( 'skins.minerva.scripts.top/mainMenu', mainMenu );
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.scripts/init.js

@@ -1,4 +1,4 @@
-( function ( M, track, config, $ ) {
+( function ( M, track, config ) {
 	var
 		toast = M.require( 'mobile.startup/toast' ),
 		time = M.require( 'mobile.startup/time' ),
@@ -368,4 +368,4 @@
 	} );
 
 	M.define( 'skins.minerva.scripts/overlayManager', overlayManager );
-}( mw.mobileFrontend, mw.track, mw.config, jQuery ) );
+}( mw.mobileFrontend, mw.track, mw.config ) );

resources/skins.minerva.scripts/initLogging.js

@@ -1,9 +1,9 @@
 // This initialises EventLogging for main menu and some prominent links in the UI.
 // This code should only be loaded on the Minerva skin, it does not apply to other skins.
-( function ( M, $ ) {
+( function ( M ) {
 	var mainMenu = M.require( 'skins.minerva.scripts.top/mainMenu' );
 
 	$( function () {
 		mainMenu.enableLogging();
 	} );
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.scripts/mobileRedirect.js

@@ -2,7 +2,7 @@
  * Warn people if they're trying to switch to desktop but have cookies disabled.
  */
 
-( function ( M, $ ) {
+( function ( M ) {
 
 	var popup = M.require( 'mobile.startup/toast' );
 
@@ -47,4 +47,4 @@
 
 	$( '#mw-mf-display-toggle' ).on( 'click', desktopViewClick );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.scripts/pageIssues.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var Page = M.require( 'mobile.startup/Page' ),
 		allIssues = {},
 		KEYWORD_ALL_SECTIONS = 'all',
@@ -216,4 +216,4 @@
 		}
 	} );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.scripts/references.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var drawer,
 		skin = M.require( 'skins.minerva.scripts/skin' ),
 		page = M.getCurrentPage(),
@@ -113,4 +113,4 @@
 	skin.on( 'references-loaded', function ( page ) {
 		setup( page );
 	} );
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.scripts/search.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var SearchOverlay = M.require( 'mobile.search/SearchOverlay' ),
 		SearchGateway = M.require( 'mobile.search.api/SearchGateway' ),
 		overlayManager = M.require( 'skins.minerva.scripts/overlayManager' ),
@@ -70,4 +70,4 @@
 		getSearchOverlay().showKeyboard();
 	} );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.tablet.scripts/toc.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var TableOfContents = M.require( 'mobile.toc/TableOfContents' ),
 		Toggler = M.require( 'mobile.toggle/Toggler' );
 
@@ -36,4 +36,4 @@
 		init( M.getCurrentPage() );
 	}
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.talk/init.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var loader = M.require( 'mobile.startup/rlModuleLoader' ),
 		LoadingOverlay = M.require( 'mobile.startup/LoadingOverlay' ),
 		$talk = $( '.talk' ),
@@ -90,4 +90,4 @@
 			}, 10 );
 		} );
 	}
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.toggling/init.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 	var page = M.getCurrentPage(),
 		$contentContainer = $( '#mw-content-text > .mw-parser-output' ),
 		Toggler = M.require( 'mobile.toggle/Toggler' );
@@ -41,4 +41,4 @@
 	) {
 		init( $contentContainer, 'content-', page );
 	}
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );

resources/skins.minerva.watchstar/init.js

@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
 
 	var Watchstar = M.require( 'mobile.watchstar/Watchstar' ),
 		user = M.require( 'mobile.startup/user' );
@@ -25,4 +25,4 @@
 	}
 	init( M.getCurrentPage() );
 
-}( mw.mobileFrontend, jQuery ) );
+}( mw.mobileFrontend ) );