From ddc1e2a30d30763a5298e9f89566d81aa997db6d Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Tue, 1 May 2018 15:04:27 -0700 Subject: [PATCH] Content area needs a z-index The content area is the sibling of the overlay. For the overlay to overlay it and its children it must explicitly setting a z-index additional changes: * Move UI styles from skins.minerva.mainMenu.styles to their more logical place (note skins.minerva.mainMenu.styles is loaded via JavaScript unncessarily) Bug: T193444 Depends-On: I7c0d02f073a2fe165a6027e3c6d1455e22c1b563 Change-Id: I8be31c7daf254e22ccaed81704cbcd2b638c54f6 --- resources/skins.minerva.base.styles/common.less | 8 ++++++++ resources/skins.minerva.mainMenu.styles/mainmenu.less | 10 ---------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/resources/skins.minerva.base.styles/common.less b/resources/skins.minerva.base.styles/common.less index 53365f3..b52a6ab 100644 --- a/resources/skins.minerva.base.styles/common.less +++ b/resources/skins.minerva.base.styles/common.less @@ -78,8 +78,16 @@ textarea { display: none !important; } +#mw-mf-viewport { + position: relative; + height: 100%; +} + // We need to ensure the content has the chrome background - otherwise it will // overlap the menu during the main menu reveal/hide animation #mw-mf-page-center { + width: 100%; + position: relative; background-color: @chromeColor; + z-index: @z-indexBase; } diff --git a/resources/skins.minerva.mainMenu.styles/mainmenu.less b/resources/skins.minerva.mainMenu.styles/mainmenu.less index ce89175..4610374 100644 --- a/resources/skins.minerva.mainMenu.styles/mainmenu.less +++ b/resources/skins.minerva.mainMenu.styles/mainmenu.less @@ -11,16 +11,6 @@ @menuItemFontSize: 0.875em; @menuItemBackgroundColor: @skinContentBgColor; -#mw-mf-viewport { - position: relative; - height: 100%; -} - -#mw-mf-page-center { - width: 100%; - position: relative; -} - // needs to be more specific than .overlay rules .notifications-overlay.navigation-drawer { right: 0;