From dc5077dbaea6e7e7744dcae7d1760a8fb213602b Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Tue, 27 Nov 2018 12:20:16 +0000 Subject: [PATCH] build: Update devDependencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit eslint-config-wikimedia 0.8.1 → 0.9.0 grunt-contrib-watch 1.0.0 → 1.1.0 grunt-stylelint 0.10.0 → 0.10.1 Change-Id: I3c8ad96f006ab4501e30d0884ae620b30f23fca8 --- .eslintrc.json | 34 +++---------------- package.json | 7 ++-- .../NotificationBadge.js | 2 +- 3 files changed, 8 insertions(+), 35 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 6a92eb6..c8c03e1 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,13 +1,12 @@ { "root": true, - "extends": "wikimedia", - "env": { - "browser": true - }, + "extends": [ + "wikimedia/client", + "wikimedia/jquery" + ], "globals": { "OO": false, "mw": false, - "$": false, "Hogan": false, "require": false }, @@ -18,31 +17,6 @@ "property": "noop", "message": "Use function() {}" }, - { - "object": "$", - "property": "isFunction", - "message": "Please use typeof" - }, - { - "object": "$", - "property": "map", - "message": "Please use Array.prototype.map instead" - }, - { - "object": "$", - "property": "isArray", - "message": "Please use Array.isArray instead" - }, - { - "object": "$", - "property": "grep", - "message": "Please use Array.prototype.filter instead" - }, - { - "object": "$", - "property": "trim", - "message": "Please use String.prototype.trim instead" - }, { "property": "done", "message": "The method `done` if used with Deferred objects is incompatible with ES6 Promises. Please use `then`." diff --git a/package.json b/package.json index d644e83..912a438 100644 --- a/package.json +++ b/package.json @@ -6,15 +6,14 @@ }, "dependencies": {}, "devDependencies": { - "eslint-config-wikimedia": "0.8.1", - "eslint-plugin-qunit": "3.3.1", + "eslint-config-wikimedia": "0.9.0", "grunt": "1.0.3", "grunt-banana-checker": "0.6.0", - "grunt-contrib-watch": "1.0.0", + "grunt-contrib-watch": "1.1.0", "grunt-eslint": "21.0.0", "grunt-jsonlint": "1.1.0", "grunt-notify": "0.4.5", - "grunt-stylelint": "0.10.0", + "grunt-stylelint": "0.10.1", "jsdoc": "3.5.5", "pre-commit": "1.2.2", "stylelint-config-wikimedia": "0.5.0", diff --git a/resources/skins.minerva.notifications.badge/NotificationBadge.js b/resources/skins.minerva.notifications.badge/NotificationBadge.js index 819ec88..deec6cd 100644 --- a/resources/skins.minerva.notifications.badge/NotificationBadge.js +++ b/resources/skins.minerva.notifications.badge/NotificationBadge.js @@ -107,7 +107,7 @@ var self = this, mainMenu = this.options.mainMenu; - this.$el.on( 'click', $.proxy( this.onClickBadge, this ) ); + this.$el.on( 'click', this.onClickBadge.bind( this ) ); this.options.overlayManager.add( /^\/notifications$/, function () { return self._loadNotificationOverlay().then( function ( overlay ) { mainMenu.openNavigationDrawer( 'secondary' );