golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Skip the flaking watchstar test 

Additional changes to tests:
* pageExists uses brower.call to avoid token error in talk
* use a before rather than beforeEach for creating articles
to avoid an unnecessary API action

Bug: T222517
Change-Id: I44cda7d62e5e4e58ed38b15ae13fdb0c8dc2e900
This commit is contained in:
jdlrobson 2019-05-07 09:14:52 -07:00
parent 4ad1b511c0
commit d455b88080
3 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/selenium/features/step_definitions/common_steps.js
View File

@ -19,7 +19,8 @@ const login = () => {
const createPages = ( pages ) => { const createPages = ( pages ) => {
const summary = 'edit by selenium test'; const summary = 'edit by selenium test';
return login().then( () => browser.call( () => login() );
browser.call( () =>
api.batch( api.batch(
pages.map( ( page ) => [ 'create' ].concat( page ).concat( [ summary ] ) ) pages.map( ( page ) => [ 'create' ].concat( page ).concat( [ summary ] ) )
) )
@ -27,7 +28,8 @@ const createPages = ( pages ) => {
}; };
const createPage = ( title, wikitext ) => { const createPage = ( title, wikitext ) => {
return login().then( () => Api.edit( title, wikitext ) ); browser.call( () => login() );
browser.call( () => Api.edit( title, wikitext ) );
}; };
const iAmUsingTheMobileSite = () => { const iAmUsingTheMobileSite = () => {
@ -56,11 +58,11 @@ const iAmLoggedIntoTheMobileWebsite = () => {
}; };
const pageExists = ( title ) => { const pageExists = ( title ) => {
return createPage( title, 'Page created by Selenium browser test.' ).then( () => { browser.call( () =>
const d = new Date(); createPage( title, 'Page created by Selenium browser test.' )
// wait 2 seconds so the change can propogate. );
browser.waitUntil( () => new Date() - d > 2000 ); // wait 2 seconds so the change can propogate.
} ); waitForPropagation( 2000 );
}; };
const iAmOnAPageThatDoesNotExist = () => { const iAmOnAPageThatDoesNotExist = () => {

2
tests/selenium/specs/search_loggedin.js
View File

@ -13,7 +13,7 @@ const {
} = require( '../features/step_definitions/search_steps' ); } = require( '../features/step_definitions/search_steps' );
// @test2.m.wikipedia.org @vagrant @login // @test2.m.wikipedia.org @vagrant @login
describe( 'Search', () => { describe.skip( 'Search', () => {
it( 'Clicking on a watchstar toggles the watchstar', () => { it( 'Clicking on a watchstar toggles the watchstar', () => {
iAmUsingTheMobileSite(); iAmUsingTheMobileSite();

7
tests/selenium/specs/talk.js
View File

@ -19,12 +19,15 @@ const { iAmOnAPageWithNoTalkTopics } = require( '../features/step_definitions/cr
// @chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org @vagrant // @chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org @vagrant
describe( 'Talk', () => { describe( 'Talk', () => {
beforeEach( () => { before( () => {
iAmUsingTheMobileSite();
pageExists( 'Talk:Selenium talk test' ); pageExists( 'Talk:Selenium talk test' );
pageExists( 'Selenium talk test' ); pageExists( 'Selenium talk test' );
} ); } );
beforeEach( () => {
iAmUsingTheMobileSite();
} );
it( 'Add discussion on talk page not possible as logged out user', () => { it( 'Add discussion on talk page not possible as logged out user', () => {
iAmOnPage( 'Selenium talk test' ); iAmOnPage( 'Selenium talk test' );
thereShouldBeNoTalkButton(); thereShouldBeNoTalkButton();