From 723deeb8bf76b16a83a6742b7078a2a7f1549ab1 Mon Sep 17 00:00:00 2001 From: Nicholas Ray Date: Mon, 29 Apr 2019 15:24:16 -0600 Subject: [PATCH] Change TalkSectionAddOverlay browser test's textarea selector In anticipation of the changes in I30aa36a0cb89988d1bad8256e5d3f737380bc0a7 which removes the .wikibase-editor selector from the TalkSectionAddOverlay textarea, the browser tests need to be changed to a more accomodating selector. Instead of finding the textarea from the .wikitext-editor selector, the tests now look for the textarea in the overlay (there is only one). This also makes it more in line with its method for finding the input element (.talk-overlay input) as well. Bug: T221624 Change-Id: Ifbba23e9aee6f68033efc3279ed737d519a7bf41 --- tests/browser/features/step_definitions/talk_steps.rb | 2 +- tests/browser/features/support/pages/article_page.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/browser/features/step_definitions/talk_steps.rb b/tests/browser/features/step_definitions/talk_steps.rb index b87f633..d3f6142 100644 --- a/tests/browser/features/step_definitions/talk_steps.rb +++ b/tests/browser/features/step_definitions/talk_steps.rb @@ -13,7 +13,7 @@ When(/^I add a topic called "(.+)"$/) do |topic| step 'I click the add discussion button' on(ArticlePage) do |page| page.talk_overlay_summary = topic - page.talk_overlay_wikitext_editor = 'Topic body is a really long text.' + page.talk_overlay_body = 'Topic body is a really long text.' page.wait_until { page.talk_overlay_save_button_element.enabled? } page.talk_overlay_save_button end diff --git a/tests/browser/features/support/pages/article_page.rb b/tests/browser/features/support/pages/article_page.rb index 82beceb..e4fc046 100644 --- a/tests/browser/features/support/pages/article_page.rb +++ b/tests/browser/features/support/pages/article_page.rb @@ -196,6 +196,6 @@ class ArticlePage p(:talk_overlay_content_header, css: '.talk-overlay .content-header') li(:talk_overlay_first_topic_title, css: '.talk-overlay .topic-title-list li:first-child') text_field(:talk_overlay_summary, css: '.talk-overlay input') - text_area(:talk_overlay_wikitext_editor, css: '.talk-overlay .wikitext-editor') + text_area(:talk_overlay_body, css: '.talk-overlay textarea') button(:talk_overlay_save_button, css: '.talk-overlay .confirm-save') end