golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Hygiene: Drop isAuthenticatedUser method 

Is used only in Minerva, and it's so simple, there is no need to
have a special function for that (no improvement no performance,
nor readability)

Change-Id: Id5a4edb077671dc12f58df31273f00a1a816f097
This commit is contained in:
Piotr Miazga 2019-06-21 19:18:27 +02:00
parent 6352190684
commit b8d5e3fac5
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
includes/skins/SkinMinerva.php
View File

@ -252,7 +252,7 @@ class SkinMinerva extends SkinTemplate {
$className .= ' page-Main_Page ';
}
if ( $this->isAuthenticatedUser() ) {
if ( $this->getUser()->isLoggedIn() ) {
$className .= ' is-authenticated';
}
// The new treatment should only apply to the main namespace
@ -265,15 +265,6 @@ class SkinMinerva extends SkinTemplate {
return $className;
}
/**
* Check whether the current user is authenticated or not.
* @todo This helper function is only truly needed whilst SkinMobileApp does not support login
* @return bool
*/
protected function isAuthenticatedUser() {
return $this->getUser()->isLoggedIn();
}
/**
* Whether the output page contains category links and the category feature is enabled.
* @return bool
@ -960,7 +951,7 @@ class SkinMinerva extends SkinTemplate {
$styles[] = 'skins.minerva.userpage.styles';
$styles[] = 'skins.minerva.userpage.icons';
}
if ( $this->isAuthenticatedUser() ) {
if ( $this->getUser()->isLoggedIn() ) {
$styles[] = 'skins.minerva.loggedin.styles';
$styles[] = 'skins.minerva.icons.loggedin';
}