From ffa4d0e848f58112fd1ad09b9e359d658cdfeab9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Fri, 21 Sep 2018 01:35:41 +0200
Subject: [PATCH] Remove some useless code trying to show things that are
 always visible

* Page edit action (#ca-edit)
  I guess it became always visible when no-JS editing was implemented?

* User page creation CTA (.edit-link)
  I'm making it always visible in Ie2fc6d43ebc03626517eec21bf4738dca05152d0
  (which also makes it available for no-JS editing).

* Section edit links for nested sub-sections (.in-block > .edit-page)
  No idea about these, but they are clearly always shown (even in
  non-article namespaces).

Depends-On: Ie2fc6d43ebc03626517eec21bf4738dca05152d0
Change-Id: I226cb1fd1e716078a4a34ed8349d5304428964cf
---
 resources/skins.minerva.editor/init.js | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/resources/skins.minerva.editor/init.js b/resources/skins.minerva.editor/init.js
index b7e4b35..ac1f571 100644
--- a/resources/skins.minerva.editor/init.js
+++ b/resources/skins.minerva.editor/init.js
@@ -95,9 +95,7 @@
 	function updateEditPageButton( enabled ) {
 		$caEdit
 			.addClass( enabled ? enabledClass : disabledClass )
-			.removeClass( enabled ? disabledClass : enabledClass )
-			// TODO: can hidden be removed from the default state?
-			.removeClass( 'hidden' );
+			.removeClass( enabled ? disabledClass : enabledClass );
 	}
 
 	/**
@@ -271,8 +269,6 @@
 			}
 		} );
 		updateEditPageButton( true );
-		// reveal edit links on user pages
-		page.$( '.edit-link' ).removeClass( 'hidden' );
 		currentPage.getRedLinks().on( 'click', function ( ev ) {
 			var drawerOptions = {
 					progressiveButton: new Button( {
@@ -313,11 +309,6 @@
 			}
 		}
 
-		// enable all edit pencils in sub-sections for the article namespace
-		if ( currentPage.getNamespaceId() === 0 ) {
-			$( '.in-block>.edit-page' ).show();
-		}
-
 		if ( !router.getPath() && ( mw.util.getParamValue( 'veaction' ) || mw.util.getParamValue( 'action' ) === 'edit' ) ) {
 			if ( mw.util.getParamValue( 'veaction' ) === 'edit' ) {
 				editorOverride = 'VisualEditor';