golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Browser: Drop failing tests 

Two tests are failing. These are false positives that
obscure real failures. Both are removed for the following reason.

1) Editor test is covered by the redirect tests - failing due to
concurrent edits (possibly because multiple browser tests act on the same
page at the same time). However, editing is already covered by the other
2 cases.

2) Remove unwatch test - this is failing as there is a problem in the
setup - the page starts unwatched when it should be watched. The test
for checking that an article can be watched should suffice here.

Bug: T224947
Change-Id: I3049e1b190c3cb2ddc198a45681f59782f770d6a
This commit is contained in:
jdlrobson 2019-07-01 15:31:17 -07:00
parent 5b92c238b3
commit a9533fc463
3 changed files with 5 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/selenium/features/editor_wikitext_saving.feature
View File

@ -4,17 +4,6 @@ Feature: Wikitext Editor (Makes actual saves)
Background:
Given I am logged into the mobile website
@editing
Scenario: It is possible to edit
Given I go to a page that has languages
When I click the edit button
And I see the wikitext editor overlay
And I type "ABC GHI" into the editor
And I click continue
And I click submit
And I do not see the wikitext editor overlay
Then I should see a toast notification
@editing @en.m.wikipedia.beta.wmflabs.org
Scenario: Redirects
Given the page "Selenium wikitext editor test" exists

17
tests/selenium/specs/editor_wikitext_saving.js
View File

@ -1,6 +1,5 @@
const { iGoToAPageThatHasLanguages } = require( './../features/step_definitions/create_page_api_steps' ),
{
pageExists, iAmOnAPageThatDoesNotExist, iShouldSeeAToastNotification,
const {
pageExists, iAmOnAPageThatDoesNotExist,
iAmLoggedIntoTheMobileWebsite
} = require( './../features/step_definitions/common_steps' ),
{
@ -17,18 +16,6 @@ describe( 'Wikitext Editor (Makes actual saves)', () => {
iAmLoggedIntoTheMobileWebsite();
} );
// @editing
it( 'It is possible to edit', () => {
iGoToAPageThatHasLanguages();
iClickTheEditButton();
iSeeTheWikitextEditorOverlay();
iTypeIntoTheEditor( 'ABC GHI' );
iClickContinue();
iClickSubmit();
iDoNotSeeTheWikitextEditorOverlay();
iShouldSeeAToastNotification();
} );
// @editing @en.m.wikipedia.beta.wmflabs.org
it( 'Redirects', () => {
const title = 'Selenium wikitext editor test ' + Math.random();

14
tests/selenium/specs/watchstar.js
View File

@ -1,12 +1,11 @@
const { iAmViewingAWatchedPage,
iAmViewingAnUnwatchedPage } = require( '../features/step_definitions/create_page_api_steps' ),
const { iAmViewingAnUnwatchedPage } = require( '../features/step_definitions/create_page_api_steps' ),
{
iShouldSeeAToastNotificationWithMessage,
iAmLoggedIntoTheMobileWebsite
} = require( '../features/step_definitions/common_steps' ),
{
theWatchstarShouldNotBeSelected, theWatchstarShouldBeSelected,
iClickTheWatchstar, iClickTheUnwatchStar } = require( '../features/step_definitions/watch_steps' );
theWatchstarShouldBeSelected,
iClickTheWatchstar } = require( '../features/step_definitions/watch_steps' );
// @chrome @smoke @test2.m.wikipedia.org @login @vagrant
describe( 'Manage Watchlist', () => {
@ -15,13 +14,6 @@ describe( 'Manage Watchlist', () => {
iAmLoggedIntoTheMobileWebsite();
} );
it( 'Remove an article from the watchlist', () => {
iAmViewingAWatchedPage();
iClickTheUnwatchStar();
iShouldSeeAToastNotificationWithMessage( 'Removed' );
theWatchstarShouldNotBeSelected();
} );
it( 'Add an article to the watchlist', () => {
iAmViewingAnUnwatchedPage();
iClickTheWatchstar();