Fix: page issue icon type determination
The page issuer parser works with plain old Elements, not jQuery. Pass in the expected type. This addresses problems with the icon display for ambox templates relating to balance (see https://phabricator.wikimedia.org/T191528#4465069) Bug: T191528 Change-Id: Ie4a34087f9f1700342cc54a50cd3272fc9ea34ee
This commit is contained in:
parent
b91dcdbd50
commit
a6ba0f2c77
|
@ -119,13 +119,13 @@
|
|||
// store it for late
|
||||
allIssues[section] = issues;
|
||||
|
||||
if ( inline ) {
|
||||
if ( $metadata.length && inline ) {
|
||||
severity = pageIssueParser.maxSeverity(
|
||||
issues.map( function ( issue ) { return issue.pageIssue; } )
|
||||
);
|
||||
new Icon( {
|
||||
glyphPrefix: 'minerva',
|
||||
name: pageIssueParser.iconName( $metadata, severity )
|
||||
name: pageIssueParser.iconName( $metadata.get( 0 ), severity )
|
||||
} ).prependTo( $metadata.find( '.mbox-text' ) );
|
||||
$learnMore = $( '<span>' )
|
||||
.addClass( 'ambox-learn-more' )
|
||||
|
|
Loading…
Reference in New Issue