From a3e524192db3dfcbffe1bb7d6f2a208b95c6addf Mon Sep 17 00:00:00 2001
From: Stephen Niedzielski <stephen@niedzielski.com>
Date: Wed, 3 Apr 2019 13:34:14 -0600
Subject: [PATCH] Hygiene: reduce getPageActions() visibility

- Reduce MinervaTemplate.getPageActions() visibility from public to
  protected. No one seems to use it.

- Use camelCase instead of lowercase for the pageActionMenu.mustache
  template's pageActions variable. writingwithcaseindifference is
  difficult to read and the templates seem to support casing.

Change-Id: I6d283c7b97eeef6902cb010904748bd8c72b660c
---
 includes/skins/MinervaTemplate.php     | 4 ++--
 includes/skins/pageActionMenu.mustache | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/includes/skins/MinervaTemplate.php b/includes/skins/MinervaTemplate.php
index 401d67c..4b09599 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -49,7 +49,7 @@ class MinervaTemplate extends BaseTemplate {
 	 * Returns available page actions
 	 * @return array
 	 */
-	public function getPageActions() {
+	protected function getPageActions() {
 		return $this->isFallbackEditor() ? [] : $this->data['page_actions'];
 	}
 
@@ -100,7 +100,7 @@ class MinervaTemplate extends BaseTemplate {
 		$html = '';
 
 		if ( $actions ) {
-			$html = $templateParser->processTemplate( 'pageActionMenu',  [ 'pageactions' => $actions ] );
+			$html = $templateParser->processTemplate( 'pageActionMenu',  [ 'pageActions' => $actions ] );
 		}
 		return $html;
 	}
diff --git a/includes/skins/pageActionMenu.mustache b/includes/skins/pageActionMenu.mustache
index f77b349..f4c4a5d 100644
--- a/includes/skins/pageActionMenu.mustache
+++ b/includes/skins/pageActionMenu.mustache
@@ -1,11 +1,11 @@
 <nav class="page-actions-menu">
 	<ul id="page-actions" class="page-actions-menu__list">
-		{{#pageactions}}
+		{{#pageActions}}
 		<li id="{{item-id}}" class="page-actions-menu__list-item">
 			<a id="{{id}}" href="{{href}}" class="{{class}}" role="button" title="{{title}}">
 				{{text}}
 			</a>
 		</li>
-		{{/pageactions}}
+		{{/pageActions}}
 	</ul>
 </nav>