From 9fc58af5095303a568015af7fde5948c0dab820f Mon Sep 17 00:00:00 2001
From: Kunal Mehta <legoktm@member.fsf.org>
Date: Sun, 15 Apr 2018 16:40:02 -0700
Subject: [PATCH] Get rid of ICustomizableSkin

As far as I can tell this interface is entirely unused.

Change-Id: I9f2ff27ab0e7f9f1e842d5e073eed5d9428f3cda
---
 includes/skins/ICustomizableSkin.php | 34 ----------------------------
 includes/skins/SkinMinerva.php       |  2 +-
 skin.json                            |  1 -
 3 files changed, 1 insertion(+), 36 deletions(-)
 delete mode 100644 includes/skins/ICustomizableSkin.php

diff --git a/includes/skins/ICustomizableSkin.php b/includes/skins/ICustomizableSkin.php
deleted file mode 100644
index 6d9e261..0000000
--- a/includes/skins/ICustomizableSkin.php
+++ /dev/null
@@ -1,34 +0,0 @@
-<?php
-/**
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-interface ICustomizableSkin {
-	/**
-	 * override an existing option or options with new values
-	 * @param array $options
-	 */
-	public function setSkinOptions( $options );
-
-	/**
-	 * Return whether a skin option is truthy
-	 * @param string $key
-	 * @return bool
-	 */
-	public function getSkinOption( $key );
-}
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 24e0bb4..f7d979c 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -27,7 +27,7 @@ use MediaWiki\Minerva\SkinUserPageHelper;
  * A skin that works on both desktop and mobile
  * @ingroup Skins
  */
-class SkinMinerva extends SkinTemplate implements ICustomizableSkin {
+class SkinMinerva extends SkinTemplate {
 	/** Set of keys for available skin options. See $skinOptions. */
 	const OPTION_MOBILE_OPTIONS = 'mobileOptionsLink';
 	const OPTION_CATEGORIES = 'categories';
diff --git a/skin.json b/skin.json
index f5379ca..3855591 100644
--- a/skin.json
+++ b/skin.json
@@ -6,7 +6,6 @@
 		"MinervaTemplate": "includes/skins/MinervaTemplate.php",
 		"SkinMinerva": "includes/skins/SkinMinerva.php",
 		"SkinMinervaNeue": "includes/skins/SkinMinerva.php",
-		"ICustomizableSkin": "includes/skins/ICustomizableSkin.php",
 		"MediaWiki\\Minerva\\MenuBuilder": "includes/skins/MenuBuilder.php",
 		"MediaWiki\\Minerva\\MenuEntry": "includes/skins/MenuEntry.php",
 		"MediaWiki\\Minerva\\ResourceLoaderLessVarFileModule": "includes/ResourceLoaderLessVarFileModule.php",