From dc6f707ea13339eab11b824f705520df5c7afff3 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Wed, 5 Sep 2018 12:49:31 -0700 Subject: [PATCH] Correct the link for page issues in the old treatment. createBanner was incorrectly always assigning the 'all' keyword to the old page issues banner. Instead it should use the section number in the function signature - as this decision of which issues to show is made inside initPageIssues For the old treatment, in the main namespace, we only show issues in the lead section. When we use the 'all' keyword the visual is the same, but it breaks the instrumentation requirement that sectionNumbers and issuesSeverity should be the correct length Note, for the talk and category pages treatment, we do not log any events so the instrumentation doesn't matter here and the 'all' keyword correctly targets all issues in the page as before. Bug: T203050 Change-Id: I63e45da05ca033fe282633f7fd59038a8e5d8c8d --- resources/skins.minerva.scripts/pageIssues.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/resources/skins.minerva.scripts/pageIssues.js b/resources/skins.minerva.scripts/pageIssues.js index dabe661..617a05c 100644 --- a/resources/skins.minerva.scripts/pageIssues.js +++ b/resources/skins.minerva.scripts/pageIssues.js @@ -188,8 +188,7 @@ } ); } else { $link = createLinkElement( labelText ); - // In group A, we link to all issues no matter where the banner is. - $link.attr( 'href', '#/issues/' + KEYWORD_ALL_SECTIONS ); + $link.attr( 'href', '#/issues/' + section ); $link.click( function () { pageIssuesLogger.log( { action: 'issueClicked',