From 967639552905495bca8b9f5b7b7c95a40a998ffa Mon Sep 17 00:00:00 2001 From: Nicholas Ray Date: Tue, 18 Jun 2019 16:34:57 -0600 Subject: [PATCH] Correct Wikidata icon color in overflow menu This icon's stroke was explicitly set to `#000` before this commit, but we need its color to be `#54595d` to match the other icons in the overflow menu [1]. Unfortunately, although we set a variant in skin.json for the icon to be colored this way [2], there are 2 problems that prevent it from displaying this color: 1) The icon sets an explicit black color for its stroke attribute 2) ResourceLoader currently only sets the fill color on the `g` element when applying the variant style [3]. It does not set the stroke color. Even if problem 1) was removed, we would need RL to set the stroke color, but I'm not sure how that would affect other variant icons that RL deals with. The simplest possible solution is to to change the stroke attribute on the icon itself, although it unfortunately introduces technical debt as this icon now differs slightly from the OOUI one :( [1] https://phabricator.wikimedia.org/T222630#5266575 [2] https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/skin.json#L262-L267 [3] https://github.com/wikimedia/mediawiki/blob/4e59467427eb74f4f66f844d24691d7037f6df02/includes/resourceloader/ResourceLoaderImage.php#L331 Bug: T222630 Change-Id: I8c10a6012c7d32ab8555b874e766bc2f36437cf8 --- resources/wikimedia.ui/logo-Wikidata.svg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/wikimedia.ui/logo-Wikidata.svg b/resources/wikimedia.ui/logo-Wikidata.svg index 3cc0c67..27a6b2d 100644 --- a/resources/wikimedia.ui/logo-Wikidata.svg +++ b/resources/wikimedia.ui/logo-Wikidata.svg @@ -1 +1 @@ -Wikidata logo \ No newline at end of file +Wikidata logo \ No newline at end of file