From 152f48b84606b78254ccfd46304125cf01cb21ad Mon Sep 17 00:00:00 2001 From: Fomafix Date: Wed, 30 May 2018 06:38:14 +0200 Subject: [PATCH] Force type Language for $lang of doEditSectionLink wfGetLangObj() is not necessary anymore. This change increases the requirement to MediaWiki 1.32 or higher. Depends-On: Id49201957e716ef8a2ea930b3616ca4fe6e35633 Change-Id: I18adeebe476b321546ceda43eb12b6cf7e8081b3 --- includes/skins/SkinMinerva.php | 5 ++--- skin.json | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 8f28dce..a402e81 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -245,12 +245,11 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin { * @param Title $nt * @param string $section * @param string|null $tooltip - * @param Language|string|bool $lang + * @param Language $lang * @return string */ - public function doEditSectionLink( Title $nt, $section, $tooltip = null, $lang = false ) { + public function doEditSectionLink( Title $nt, $section, $tooltip = null, Language $lang ) { if ( $this->isAllowedPageAction( 'edit' ) ) { - $lang = wfGetLangObj( $lang ); $message = $this->msg( 'mobile-frontend-editor-edit' )->inLanguage( $lang )->text(); $html = Html::openElement( 'span' ); $html .= Html::element( 'a', [ diff --git a/skin.json b/skin.json index 9ee3814..a6513ff 100644 --- a/skin.json +++ b/skin.json @@ -7,7 +7,7 @@ "url": "https://www.mediawiki.org/wiki/Skin:MinervaNeue", "license-name": "GPL-2.0-or-later", "requires": { - "MediaWiki": ">= 1.25.0", + "MediaWiki": ">= 1.32.0", "extensions": { "MobileFrontend": ">= 2.1.0" }