Merge "Drop unused parameter in NotificationBadge"

This commit is contained in:
jenkins-bot 2019-03-19 21:07:48 +00:00 committed by Gerrit Code Review
commit 89b67716c2
1 changed files with 0 additions and 13 deletions

View File

@ -29,10 +29,6 @@
options.title = $el.find( 'a' ).attr( 'title' );
options.url = $el.find( 'a' ).attr( 'href' );
count = Number( $el.find( 'span' ).data( 'notification-count' ) );
options.onError = function () {
// FIXME: Blocked on T189173. Ideally we'd use the router here.
window.location.href = this.getNotificationURL();
}.bind( this );
}
View.call( this,
util.extend( options, {
@ -142,15 +138,6 @@
// be binded on #mw-mf-page-center that close overlay
return false;
},
/**
* Return the URL for the full non-overlay notification view
* @memberof NotificationBadge
* @instance
* @return {string} url
*/
getNotificationURL: function () {
return this.options.url;
},
/**
* Update the notification count
* @memberof NotificationBadge