golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Hygiene: Cleanup schemaMobileWebMainMenuClickTracking sampling rate logic 

AMC mode is already determined prior to the `trackSubscribe` callback
executing so we can set the sampling rate outside
the callback as well.

Hopefully, this improves readability. If not, I'm happy to abandon this
patch.

Change-Id: Ic1386c0e31ae7fbdd52f18d3b881ec6a5fb5a67c
This commit is contained in:
Nicholas Ray 2019-04-26 10:07:22 -06:00
parent b308c33a74
commit 858935210b
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
resources/skins.minerva.scripts/menu/schema.js
View File

@ -10,6 +10,9 @@ mw.loader.using( [
// Schema provided by ext.eventLogging.subscriber class
Schema = mw.eventLog.Schema, // resource-modules-disable-line
context = M.require( 'mobile.startup' ).context,
DEFAULT_SAMPLING_RATE = mw.config.get( 'wgMinervaSchemaMainMenuClickTrackingSampleRate' ),
// T218627: Sampling rate should be 100% if user has amc enabled
AMC_SAMPLING_RATE = 1,
/**
* MobileWebMainMenuClickTracking schema
* https://meta.wikimedia.org/wiki/Schema:MobileWebMainMenuClickTracking
@ -19,7 +22,7 @@ mw.loader.using( [
*/
schemaMobileWebMainMenuClickTracking = new Schema(
'MobileWebMainMenuClickTracking',
mw.config.get( 'wgMinervaSchemaMainMenuClickTrackingSampleRate' ),
amc ? AMC_SAMPLING_RATE : DEFAULT_SAMPLING_RATE,
/**
* @property {Object} defaults Default options hash.
* @property {string} defaults.mode whether user is in stable, beta, or desktop
@ -44,12 +47,6 @@ mw.loader.using( [
);
mw.trackSubscribe( 'minerva.schemaMobileWebMainMenuClickTracking', function ( topic, data ) {
if ( amc ) {
// T218627: Sampling rate should be 100% if user has amc enabled
schemaMobileWebMainMenuClickTracking.log( data, 1 );
return;
}
schemaMobileWebMainMenuClickTracking.log( data );
} );
} );