From 79fd8bd7996a90e6a54879d5b2aae9c279202ad0 Mon Sep 17 00:00:00 2001
From: jdlrobson <jdlrobson@gmail.com>
Date: Mon, 28 Aug 2017 15:47:05 -0500
Subject: [PATCH] Hygiene: Remove FIXMEs now enough time has passed

Routine maintenance - all FIXME statements suggest these can
be removed. W00t!

Depends-On: Iee059a6605cf12a073954378f49ddc721a7e016a
Change-Id: I645dca1fa4d9e80d506e907b0be78a5aef0e2f12
---
 resources/skins.minerva.base.styles/footer.less | 10 ----------
 resources/skins.minerva.base.styles/ui.less     | 17 -----------------
 .../skins.minerva.content.styles/lists.less     |  7 -------
 resources/skins.minerva.tablet.scripts/toc.js   |  4 +---
 .../mediawiki.action.edit.styles/minerva.less   |  3 ---
 5 files changed, 1 insertion(+), 40 deletions(-)

diff --git a/resources/skins.minerva.base.styles/footer.less b/resources/skins.minerva.base.styles/footer.less
index b0a0d0f..b3739df 100644
--- a/resources/skins.minerva.base.styles/footer.less
+++ b/resources/skins.minerva.base.styles/footer.less
@@ -31,11 +31,6 @@ footer {
 		position: absolute;
 		right: -1em;
 
-		// FIXME: Remove pseudo selector rule in 1 weeks time [T145479]
-		&:before {
-			.transform( rotate( -90deg ) );
-		}
-
 		.client-nojs & {
 			// Certain browsers e.g. Opera Mini do not support css transforms
 			// We assume that we do not run JS on these browsers so hide the chevron
@@ -70,11 +65,6 @@ footer {
 	}
 }
 
-// FIXME: Remove pseudo selector rule in 1 weeks time [T145479]
-.rtl footer .indicator:before {
-	.transform( rotate( 90deg ) );
-}
-
 @media ( min-width: @deviceWidthTablet ) {
 	footer {
 		.last-modified-bar {
diff --git a/resources/skins.minerva.base.styles/ui.less b/resources/skins.minerva.base.styles/ui.less
index 74668e9..31f3dec 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -150,21 +150,6 @@ body {
 	}
 }
 
-// Make search input more visible for users on small screens.
-// Opera Mini doesn't support placeholders.
-// FIXME: As soon as HeaderV2 feature flag is removed this entire block can disappear as a search icon
-// will now be shown on Opera Mini instead.
-@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
-	.header {
-		.search {
-			border: 1px solid @grayLight;
-			// Remove the space for the search icon inside the search bar and increase height to size of button
-			padding: 0.5em 0.1em;
-			background: none;  // so that the icon doesn't overlap with the placeholder
-		}
-	}
-}
-
 #searchInput {
 	cursor: text;
 }
@@ -177,8 +162,6 @@ body {
 }
 
 .search-box {
-	// FIXME: remove when micro.tap in stable and rule from common-js.less too
-	-webkit-tap-highlight-color: rgba( 255, 255, 255, 0 );
 
 	.search {
 		@searchIconSize: 20px;
diff --git a/resources/skins.minerva.content.styles/lists.less b/resources/skins.minerva.content.styles/lists.less
index 31aff13..9d41525 100644
--- a/resources/skins.minerva.content.styles/lists.less
+++ b/resources/skins.minerva.content.styles/lists.less
@@ -1,10 +1,3 @@
-@import 'mediawiki.mixins.less';
-@import 'minerva.variables.less';
-@import 'minerva.mixins.less';
-
-// FIXME: Delete this in 7 days time (T42062)
-@import '../../skinStyles/mediawiki.hlist/minerva.less';
-
 .content {
 	ul {
 		list-style: square inside;
diff --git a/resources/skins.minerva.tablet.scripts/toc.js b/resources/skins.minerva.tablet.scripts/toc.js
index c4c6b83..ba26354 100644
--- a/resources/skins.minerva.tablet.scripts/toc.js
+++ b/resources/skins.minerva.tablet.scripts/toc.js
@@ -15,9 +15,7 @@
 			$toc = $( '#toc' ),
 			enableToc = mw.config.get( 'wgMinervaTocEnabled' );
 
-		if ( enableToc ||
-			// Fallback for old cached HTML, added 26 June, 2014
-			( enableToc === null && sections.length > 0 && !page.isMainPage() ) ) {
+		if ( enableToc ) {
 			toc = new TableOfContents( {
 				sections: sections
 			} );
diff --git a/skinStyles/mediawiki.action.edit.styles/minerva.less b/skinStyles/mediawiki.action.edit.styles/minerva.less
index c5c8e63..4558d9b 100644
--- a/skinStyles/mediawiki.action.edit.styles/minerva.less
+++ b/skinStyles/mediawiki.action.edit.styles/minerva.less
@@ -1,7 +1,4 @@
 // Additional Styles for no-js editing mode
-
-// FIXME: `mobile.` LESS modules should not import `minerva.` LESS modules.
-// Move Minerva specific rules into skinStyles.
 @import 'minerva.mixins';
 
 .editHelp, .cancelLink, .mw-editButtons-pipe-separator {