From 6daf19dfb57d8421eceb504722e061a9b5de448b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 21 Sep 2018 23:24:07 +0200 Subject: [PATCH] Remove user page CTA edit link browser test (move to MobileFrontend) This is a MobileFrontend feature, implemented in ExtMobileFrontend::getUserPageContent(). Having the test for it in the Minerva repo made it harder to make changes to it. Adding it there in I7cac24cf64422212196439bf49598ed749d5fafa. Depends-On I7cac24cf64422212196439bf49598ed749d5fafa Change-Id: I93e0f195b3cad1ae83ee2ae3b5b4c5f08944882e --- .../features/step_definitions/user_page_steps.rb | 11 ----------- tests/browser/features/support/pages/user_page.rb | 4 ---- tests/browser/features/user_page.feature | 6 ------ 3 files changed, 21 deletions(-) diff --git a/tests/browser/features/step_definitions/user_page_steps.rb b/tests/browser/features/step_definitions/user_page_steps.rb index 936ed10..a10c0cd 100644 --- a/tests/browser/features/step_definitions/user_page_steps.rb +++ b/tests/browser/features/step_definitions/user_page_steps.rb @@ -22,14 +22,3 @@ end Then(/^there should be a link to my uploads$/) do expect(on(UserPage).uploads_link_element).to be_visible end - -Then(/^there should be a link to create my user page$/) do - expect(on(UserPage).edit_link_element).to be_visible -end - -When(/^I click the create my user page link$/) do - on(UserPage) do |page| - page.wait_until_rl_module_ready('skins.minerva.editor') - page.edit_link_element.click - end -end diff --git a/tests/browser/features/support/pages/user_page.rb b/tests/browser/features/support/pages/user_page.rb index 77b0803..1c82d8e 100644 --- a/tests/browser/features/support/pages/user_page.rb +++ b/tests/browser/features/support/pages/user_page.rb @@ -5,7 +5,6 @@ class UserPage < ArticlePage h1(:heading, css: '#section_0') ul(:user_links, css: '.user-links') - div(:cta_holder, css: '.cta-holder') a(:talk_link) do |page| page.user_links_element.element.a(href: /User_talk:/) end @@ -15,7 +14,4 @@ class UserPage < ArticlePage a(:uploads_link) do |page| page.user_links_element.element.a(href: /Special:Uploads\//) end - a(:edit_link) do |page| - page.cta_holder_element.element.a(href: %r{#/editor/0}) - end end diff --git a/tests/browser/features/user_page.feature b/tests/browser/features/user_page.feature index 3733318..4170a9c 100644 --- a/tests/browser/features/user_page.feature +++ b/tests/browser/features/user_page.feature @@ -11,9 +11,3 @@ Feature: User: And there should be a link to my talk page And there should be a link to my contributions And there should be a link to my uploads - - Scenario: Check user page is editable - And I should be on my user page - And there should be a link to create my user page - When I click the create my user page link - Then I see the wikitext editor overlay