From 6d243c1df0aad46c67a577b1b9c3ffe9cc8656b8 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Wed, 16 Jan 2019 11:29:27 -0800 Subject: [PATCH] QA: Page Issues browser test should wait till JS has finished loading Clicking the page issue banner (which is ready from first paint to be clicked) will not yield the overlay. The user must wait for the JS to load. Likely the reason for Minerva browser test failures against beta cluster. Change-Id: I06c488ca64dd44ad24368a1d6b47bb2646ad4552 --- tests/browser/features/step_definitions/issues_steps.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/browser/features/step_definitions/issues_steps.rb b/tests/browser/features/step_definitions/issues_steps.rb index c9ed395..e9ac6b0 100644 --- a/tests/browser/features/step_definitions/issues_steps.rb +++ b/tests/browser/features/step_definitions/issues_steps.rb @@ -15,6 +15,7 @@ When(/^this page has issues$/) do end Then(/^I should not see the issues overlay$/) do + on(ArticlePage).wait_until_rl_module_ready('skins.minerva.scripts') expect(on(ArticlePage).overlay_element).not_to be_visible end