From 679a45677e0766081913980a942b2e48ae36406d Mon Sep 17 00:00:00 2001 From: Alangi Derick Date: Thu, 1 Nov 2018 14:35:57 +0100 Subject: [PATCH] Explicitly use "MediaWiki\Minerva\SkinUserPageHelper;" on-top of file To make things neat, use "MediaWiki\Minerva\SkinUserPageHelper;" at the top of the file and then mock class directly (shorter and easily readable). Change-Id: Ie2ee64e75c38fff77d41af20bdea01015ed39a87 --- tests/phpunit/skins/SkinMinervaPageActionsTest.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/skins/SkinMinervaPageActionsTest.php b/tests/phpunit/skins/SkinMinervaPageActionsTest.php index ccdfb3e..6dcca37 100644 --- a/tests/phpunit/skins/SkinMinervaPageActionsTest.php +++ b/tests/phpunit/skins/SkinMinervaPageActionsTest.php @@ -7,6 +7,7 @@ use MediaWikiTestCase; use Title; use RequestContext; use ContentHandler; +use MediaWiki\Minerva\SkinUserPageHelper; // FIXME: That this class exists is an indicator that at least SkinMinerva#isAllowedPageAction // should be extracted from SkinMinerva. @@ -130,7 +131,7 @@ class SkinMinervaPageActionsTest extends MediaWikiTestCase { * @covers SkinMinerva::isAllowedPageAction */ public function testPageActionsWhenOnUserPage() { - $userPageHelper = $this->getMockBuilder( \MediaWiki\Minerva\SkinUserPageHelper::class ) + $userPageHelper = $this->getMockBuilder( SkinUserPageHelper::class ) ->disableOriginalConstructor() ->getMock(); @@ -148,7 +149,7 @@ class SkinMinervaPageActionsTest extends MediaWikiTestCase { * @covers SkinMinerva::isAllowedPageAction */ public function testPageActionsWhenNotOnUserPage() { - $userPageHelper = $this->getMockBuilder( \MediaWiki\Minerva\SkinUserPageHelper::class ) + $userPageHelper = $this->getMockBuilder( SkinUserPageHelper::class ) ->disableOriginalConstructor() ->getMock();