Merge "EventLogging modules should be soft dependencies"

This commit is contained in:
jenkins-bot 2017-09-27 21:09:49 +00:00 committed by Gerrit Code Review
commit 67766539f9
3 changed files with 15 additions and 10 deletions

View File

@ -168,6 +168,9 @@
* @method * @method
*/ */
function logInit( editor ) { function logInit( editor ) {
// If MobileFrontend is not available this will not be possible so
// check first.
mw.loader.using( 'mobile.loggingSchemas.edit' ).done( function () {
mw.track( 'mf.schemaEdit', { mw.track( 'mf.schemaEdit', {
action: 'init', action: 'init',
type: 'section', type: 'section',
@ -175,7 +178,9 @@
editor: editor, editor: editor,
editingSessionId: editorOptions.sessionId editingSessionId: editorOptions.sessionId
} ); } );
} );
} }
/** /**
* Load source editor * Load source editor
* @private * @private

View File

@ -36,6 +36,8 @@
* attributes on elements. * attributes on elements.
*/ */
enableLogging: function () { enableLogging: function () {
// Load the EventLogging module inside MobileFrontend if available
mw.loader.using( 'mobile.loggingSchemas.mobileWebMainMenuClickTracking' );
this.$( 'a' ).on( 'click', function () { this.$( 'a' ).on( 'click', function () {
var $link = $( this ), var $link = $( this ),
eventName = $link.data( 'event-name' ); eventName = $link.data( 'event-name' );

View File

@ -233,8 +233,7 @@
"dependencies": [ "dependencies": [
"skins.minerva.mainMenu.icons", "skins.minerva.mainMenu.icons",
"skins.minerva.mainMenu.styles", "skins.minerva.mainMenu.styles",
"mobile.startup", "mobile.startup"
"mobile.loggingSchemas.mobileWebMainMenuClickTracking"
], ],
"position": "bottom", "position": "bottom",
"templates": { "templates": {
@ -360,8 +359,7 @@
"mediawiki.ui.input", "mediawiki.ui.input",
"mobile.startup", "mobile.startup",
"skins.minerva.toggling", "skins.minerva.toggling",
"mediawiki.jqueryMsg", "mediawiki.jqueryMsg"
"mobile.loggingSchemas.edit"
], ],
"messages": { "messages": {
"0": "mobile-frontend-editor-disabled", "0": "mobile-frontend-editor-disabled",