Merge "isBorderBox and className properties are deprecated"

This commit is contained in:
jenkins-bot 2018-11-27 13:58:37 +00:00 committed by Gerrit Code Review
commit 645073e958
3 changed files with 16 additions and 12 deletions

View File

@ -1,5 +1,6 @@
( function ( M ) {
var View = M.require( 'mobile.startup/View' ),
util = M.require( 'mobile.startup/util' ),
Icon = M.require( 'mobile.startup/Icon' ),
notificationIcon = new Icon( {
name: 'notifications',
@ -30,7 +31,11 @@
window.location.href = this.getNotificationURL();
}.bind( this );
}
View.call( this, options );
View.call( this,
util.extend( options, {
isBorderBox: false
} )
);
this.url = options.url;
this._bindOverlayManager();
this.setCount( count );
@ -53,7 +58,6 @@
hasUnseenNotifications: false,
notificationCountRaw: 0
},
isBorderBox: false,
/**
* Loads a ResourceLoader module script. Shows ajax loader whilst loading.
* @method

View File

@ -1,18 +1,23 @@
( function ( M ) {
var View = M.require( 'mobile.startup/View' );
var View = M.require( 'mobile.startup/View' ),
util = M.require( 'mobile.startup/util' );
/**
* Displays a little arrow at the bottom right of the viewport.
* @class BackToTopOverlay
* @extends View
* @param {Object} props
*/
function BackToTopOverlay() {
View.apply( this, arguments );
function BackToTopOverlay( props ) {
View.call( this,
util.extend( {}, props, {
className: 'backtotop'
} )
);
}
OO.mfExtend( BackToTopOverlay, View, {
className: 'backtotop',
template: mw.template.get( 'skins.minerva.options', 'BackToTopOverlay.hogan' ),
events: $.extend( {}, View.prototype.events, {
click: 'onBackToTopClick'

View File

@ -27,17 +27,12 @@
Overlay.call( this, {
issues: issues,
className: 'overlay overlay-issues',
heading: '<strong>' + headingText + '</strong>'
} );
}
OO.mfExtend( PageIssuesOverlay, Overlay, {
/**
* @memberof PageIssuesOverlay
* @instance
*/
className: 'overlay overlay-issues',
/**
* @memberof PageIssuesOverlay
* @instance