From 606e72ab68a53c80ec08cfeef3f20d33304966b2 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Wed, 27 Sep 2017 14:47:01 -0500 Subject: [PATCH] Revision::newFromTitle may return null Bug: T176882 Change-Id: I9aea25c2db81a12f16414edcb279f3241dc380bc --- includes/skins/SkinMinerva.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index cc09b05..102bef4 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -746,7 +746,12 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin { $historyUrl = $title->getLocalURL( [ 'action' => 'history' ] ); } - $editor = $this->getRevisionEditor( Revision::newFromTitle( $title ) ); + $rev = Revision::newFromTitle( $title ); + if ( $rev ) { + $editor = $this->getRevisionEditor( $rev ); + } else { + $editor = false; + } return [ // Use $edit['timestamp'] (Unix format) instead of $timestamp (MW format) 'data-timestamp' => $isMainPage ? '' : wfTimestamp( TS_UNIX, $timestamp ),