Update: link icons for standard density displays and CSS

The previous lot of link icons look great on high DPI displays but not
as nice as they could on standard resolution displays. According to
Volker, this is because the SVG paths must appear on integer coordinates
and scale up instead of down. The new assets have been designed with
this consideration in mind.

Also, workaround redundant CSS by adding commenting out the "unvaried"
black SVG background-image selector, selectorWithoutVariant.

Bug: T190549
Bug: T197909
Change-Id: Id341d383018a436401541e82cc75d826688eaaae
This commit is contained in:
Stephen Niedzielski 2018-06-21 13:18:20 -05:00
parent f943abd854
commit 5d938aa9e8
6 changed files with 8 additions and 6 deletions

View File

@ -1 +1 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?><svg xmlns="http://www.w3.org/2000/svg" width="10" height="10" viewBox="0 0 10 10" id="svg8"><title id="title2">external link</title><path d="M8.5 8.5h-7v-7H4v-1H1.5a1 1 0 0 0-1 1v7a1 1 0 0 0 1 1h7a1 1 0 0 0 1-1V6h-1z" id="path4" stroke-width=".5"/><path d="M9.5.5h-4l1.645 1.645L4.28 5.01l.71.71 2.865-2.865L9.5 4.5z" id="path6" stroke-width=".5"/></svg>
<?xml version="1.0" encoding="utf-8"?><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10"><g><path d="M8.9 8.9H1.1V1.1h2.8V0H1.1C.5 0 0 .5 0 1.1v7.8C0 9.5.5 10 1.1 10h7.8c.6 0 1.1-.5 1.1-1.1V6.1H8.9v2.8z"/><path d="M10 0H5.6l1.8 1.8L4.2 5l.8.8 3.2-3.2L10 4.4V0z"/></g></svg>

Before

Width:  |  Height:  |  Size: 409 B

After

Width:  |  Height:  |  Size: 282 B

View File

@ -1 +1 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?><svg xmlns="http://www.w3.org/2000/svg" width="10" height="10" viewBox="0 0 10 10" id="svg8"><title id="title2">external link</title><path d="M1.5 6h-1v2.5c0 .55.45 1 1 1h7c.55 0 1-.45 1-1v-7c0-.55-.45-1-1-1H6v1h2.5v7h-7z" id="path4" stroke-width=".5"/><path d="M.5 4.5l1.65-1.65L5 5.7l.7-.7-2.85-2.85L4.5.5h-4z" id="path6" stroke-width=".5"/></svg>
<?xml version="1.0" encoding="utf-8"?><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10"><g><path d="M1.1 8.9h7.8V1.1H6.1V0h2.8c.6 0 1.1.5 1.1 1.1v7.8c0 .6-.5 1.1-1.1 1.1H1.1C.5 10 0 9.5 0 8.9V6.1h1.1v2.8z"/><path d="M0 0h4.4L2.6 1.8 5.8 5l-.8.8-3.2-3.2L0 4.4V0z"/></g></svg>

Before

Width:  |  Height:  |  Size: 403 B

After

Width:  |  Height:  |  Size: 284 B

View File

@ -1 +1 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?><svg xmlns="http://www.w3.org/2000/svg" width="10" height="10" viewBox="0 0 10 10" id="svg8"><title id="title2">interwiki link</title><path d="M6 8.5v1h2.5c.55 0 1-.45 1-1v-7c0-.55-.45-1-1-1h-7c-.55 0-1 .45-1 1V4h1V1.5h7v7z" id="path4" stroke-width=".5"/><path d="M3.15 2.85L4.8 4.5.5 8.8l.7.7 4.3-4.3 1.65 1.65v-4z" id="path6" stroke-width=".5"/></svg>
<?xml version="1.0" encoding="utf-8"?><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10"><path d="M8.9 8.9V1.1H1.1v2.8H0V1.1C0 .5.5 0 1.1 0h7.8c.6 0 1.1.5 1.1 1.1v7.8c0 .6-.5 1.1-1.1 1.1H6.1V8.9h2.8z"/><path d="M6.8 3.2v4.4L5 5.8.8 10 0 9.2 4.2 5 2.4 3.2h4.4z"/></svg>

Before

Width:  |  Height:  |  Size: 407 B

After

Width:  |  Height:  |  Size: 277 B

View File

@ -1 +1 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?><svg xmlns="http://www.w3.org/2000/svg" width="10" height="10" viewBox="0 0 10 10" id="svg8"><title id="title2">interwiki link</title><path d="M1.5 8.5v-7h7V4h1V1.5c0-.55-.45-1-1-1h-7c-.55 0-1 .45-1 1v7c0 .55.45 1 1 1H4v-1z" id="path4" stroke-width=".5"/><path d="M2.85 2.85v4L4.5 5.2l4.3 4.3.7-.7-4.3-4.3 1.65-1.65z" id="path6" stroke-width=".5"/></svg>
<?xml version="1.0" encoding="utf-8"?><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10"><g><path d="M1.1 8.9V1.1h7.8v2.8H10V1.1C10 .5 9.5 0 8.9 0H1.1C.5 0 0 .5 0 1.1v7.8C0 9.5.5 10 1.1 10h2.8V8.9H1.1z"/><path d="M3.2 3.2v4.4L5 5.8 9.2 10l.8-.8L5.8 5l1.8-1.8H3.2z"/></g></svg>

Before

Width:  |  Height:  |  Size: 408 B

After

Width:  |  Height:  |  Size: 285 B

View File

@ -42,6 +42,8 @@ a {
&.extiw, // internal
&.external {
// background-image is specified by ResourceLoader.
// Force the image size to be 10px.
.background-size( 10px, 10px );
background-repeat: no-repeat;
background-position: center right;
padding-right: 13px;

View File

@ -174,8 +174,8 @@
},
"skins.minerva.content.styles.images": {
"class": "ResourceLoaderImageModule",
"selectorWithoutVariant": "a.{name}",
"selectorWithVariant": "a.{name}",
"selectorWithoutVariant": "/* T197909",
"selectorWithVariant": "*/ a.{name}",
"variants": {
"standard": {
"color": "#36c",