From 5c40ddc477ed139e15459da7114fbc13b97ae4f5 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Mon, 26 Nov 2018 14:12:26 -0800 Subject: [PATCH] Zero is a sensible default for this feature flag Bug: T205008 Depends-On: I3640b28c6a930f6e934d22c3375bffcd539902aa Change-Id: Ie5d63e265469219063e36d6e398fd0a0b1e864db --- resources/skins.minerva.mainMenu/schema.js | 3 +-- skin.json | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/resources/skins.minerva.mainMenu/schema.js b/resources/skins.minerva.mainMenu/schema.js index 09dcfff..200a558 100644 --- a/resources/skins.minerva.mainMenu/schema.js +++ b/resources/skins.minerva.mainMenu/schema.js @@ -21,8 +21,7 @@ mw.loader.using( [ */ schemaMobileWebMainMenuClickTracking = new Schema( 'MobileWebMainMenuClickTracking', - // todo: use a default value of 0 once config lands in production (T205008). - mw.config.get( 'wgMinervaSchemaMainMenuClickTrackingSampleRate', 0.5 ), + mw.config.get( 'wgMinervaSchemaMainMenuClickTrackingSampleRate' ), /** * @property {Object} defaults Default options hash. * @property {string} defaults.mobileMode whether user is in stable or beta diff --git a/skin.json b/skin.json index cc1d8dc..32d43f4 100644 --- a/skin.json +++ b/skin.json @@ -51,7 +51,7 @@ "base": false, "beta": true }, - "MinervaSchemaMainMenuClickTrackingSampleRate": 0.5, + "MinervaSchemaMainMenuClickTrackingSampleRate": 0, "MinervaABSamplingRate": 0 }, "ValidSkinNames": {