From 5a3a8efc314ac44744d8d37480f6ae001cbc3456 Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Tue, 18 Jun 2019 15:38:33 -0400 Subject: [PATCH] Use wgRelevantPageTitle when setting up talk overlay wgRelevantPageTitle is generally the same as wgPageTitle. It is different on special pages that act on a page. For example, on Special:WhatLinksHere/Moai wgPageTitle => Special:WhatLinksHere wgRelevantPageTitle => Moai This change would allow Special:Homepage to have the talk overlay connected to its talk tab. If Minerva has such special pages that act on a page AND those pages have talk links AND the 'skins.minerva.talk' happens to be loaded, those links would now show the talk overlay. I found no such cases but I cannot say they don't exist. I also don't know if this change would be a regression or an improvement. Bug: T225659 Change-Id: I5d60ff3f0295f44a6d59cd772e27656b69ef0972 --- resources/skins.minerva.talk/init.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/skins.minerva.talk/init.js b/resources/skins.minerva.talk/init.js index 90270b8..c768154 100644 --- a/resources/skins.minerva.talk/init.js +++ b/resources/skins.minerva.talk/init.js @@ -26,7 +26,7 @@ // page) // (https://www.mediawiki.org/wiki/Manual:Using_custom_namespaces#Creating_a_custom_namespace) // The method to get associated namespaces will change later (maybe), see T487 - pageTitle = mw.Title.newFromText( mw.config.get( 'wgPageName' ) ); + pageTitle = mw.Title.newFromText( mw.config.get( 'wgRelevantPageName' ) ); talkTitle = title ? mw.Title.newFromText( title ) : pageTitle.getTalkPage(); // Check that there is a valid page and talk title