golem/MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable print button on iOS

Browse Source 
As documented on the ticket, iOS does not provide PDF functionality
via print.

iOS 11 provides PDF generation but the resulting PDF is unreadable for
our content and missing styles (see T177215#3700576) and we do not know
of any way to invoke that just yet.

Bug: T177215
Change-Id: I7e195ae067625c7865dccee31fa7a2c3c0ee57e5
This commit is contained in:
jdlrobson 2017-10-20 12:54:00 -07:00 committed by Sam Smith
parent 45a1b3b423
commit 571895b754
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
resources/skins.minerva.scripts/init.js
View File

@ -261,8 +261,13 @@
initHistoryLink( $( '.last-modifier-tagline a' ) );
M.on( 'resize', loadTabletModules );
loadTabletModules();
if ( config.get( 'wgMinervaDownloadIcon' ) && !page.isMainPage() ) {
if (
config.get( 'wgMinervaDownloadIcon' ) &&
!page.isMainPage() &&
// The iOS print dialog does not provide pdf functionality (see T177215)
!browser.isIos()
) {
// Because the page actions are floated to the right, their order in the
// DOM is reversed in the display. The watchstar is last in the DOM and
// left-most in the display. Since we want the download button to be to