Merge "Fix skipped tests"
This commit is contained in:
commit
4c05ae758f
|
@ -27,8 +27,14 @@
|
|||
assert.strictEqual( badge.options.notificationCountRaw, 100, 'Number is capped to 100.' );
|
||||
} );
|
||||
|
||||
QUnit.skip( '#setCount (Eastern Arabic numerals)', function ( assert ) {
|
||||
var badge = new NotificationBadge( {
|
||||
QUnit.test( '#setCount (Eastern Arabic numerals)', function ( assert ) {
|
||||
var badge;
|
||||
|
||||
this.sandbox.stub( mw.language, 'convertNumber' )
|
||||
.withArgs( 2 ).returns( '۲' )
|
||||
.withArgs( 5 ).returns( '۵' );
|
||||
|
||||
badge = new NotificationBadge( {
|
||||
overlayManager: this.OverlayManager,
|
||||
el: $( '<div><a title="n" href="/" class="notification-unseen"><div class="circle" ><span data-notification-count="2">۲</span></div></a></div>' )
|
||||
} );
|
||||
|
|
|
@ -47,9 +47,10 @@
|
|||
),
|
||||
labelText = 'label text',
|
||||
inline = true,
|
||||
SECTION = '0',
|
||||
processedAmbox = createBanner(
|
||||
new Page( { el: $mockContainer } ),
|
||||
labelText, '0', inline, overlayManager
|
||||
labelText, SECTION, inline, overlayManager
|
||||
);
|
||||
|
||||
QUnit.module( 'Minerva cleanuptemplates' );
|
||||
|
@ -63,18 +64,20 @@
|
|||
} );
|
||||
QUnit.test( 'clicking on the product of createBanner() should trigger a URL change', function ( assert ) {
|
||||
processedAmbox.click();
|
||||
assert.strictEqual( window.location.hash, '#/issues/0' );
|
||||
assert.strictEqual( window.location.hash, '#/issues/' + SECTION );
|
||||
} );
|
||||
|
||||
// NOTE: Only for PageIssues AB
|
||||
QUnit.skip( 'clicking on the product of createBanner() should trigger a custom event', function ( assert ) {
|
||||
QUnit.test( 'clicking on the product of createBanner() should trigger a custom event', function ( assert ) {
|
||||
var mockAction = {
|
||||
action: 'issueClicked',
|
||||
issueSeverity: [ 'MEDIUM' ]
|
||||
issuesSeverity: [ 'MEDIUM' ],
|
||||
sectionNumbers: [ SECTION ]
|
||||
};
|
||||
mw.trackSubscribe( 'minerva.PageIssuesAB', function ( topic, data ) {
|
||||
assert.deepEqual( mockAction, data );
|
||||
} );
|
||||
processedAmbox.click();
|
||||
} );
|
||||
|
||||
QUnit.test( 'formatPageIssuesSeverity', function ( assert ) {
|
||||
|
|
Loading…
Reference in New Issue