From 44ed0f5e69b7b01cb9eab8608f020541f2459595 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Wed, 13 Feb 2019 11:42:15 -0800 Subject: [PATCH] Talk tab select should sit on top of page actions Per design review with Alex. Bug: T212216 Change-Id: Id4e1f5167c50a8d75a0682c4e8ed219c36b93be3 --- minerva.less/minerva.variables.less | 2 +- resources/skins.minerva.amc.styles/tabs.less | 2 +- resources/skins.minerva.base.styles/pageactions.less | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/minerva.less/minerva.variables.less b/minerva.less/minerva.variables.less index 7526935..4e4e63a 100644 --- a/minerva.less/minerva.variables.less +++ b/minerva.less/minerva.variables.less @@ -46,8 +46,8 @@ @titleSectionSpacingBottom: 25px; // Page actions -@tabBorderSize: ( 1em / 16px ) * 2; @taglineFontSize: 0.85em; +@pageActionBorder: 1px; // colors @chromeColor: @grayLightest; diff --git a/resources/skins.minerva.amc.styles/tabs.less b/resources/skins.minerva.amc.styles/tabs.less index e604836..f22a6ab 100644 --- a/resources/skins.minerva.amc.styles/tabs.less +++ b/resources/skins.minerva.amc.styles/tabs.less @@ -18,6 +18,6 @@ } // note core doesn't use BEM. &.selected { - border-bottom: @tabBorderSize solid @colorGray5; + border-bottom: (@pageActionBorder * 2) solid @colorGray5; } } diff --git a/resources/skins.minerva.base.styles/pageactions.less b/resources/skins.minerva.base.styles/pageactions.less index b1789dc..5010f7b 100644 --- a/resources/skins.minerva.base.styles/pageactions.less +++ b/resources/skins.minerva.base.styles/pageactions.less @@ -25,8 +25,8 @@ overflow: hidden; width: 100%; margin-top: -2px; - border-top: 1px solid @colorGray14; - border-bottom: 1px solid @colorGray12; + border-top: @pageActionBorder solid @colorGray14; + border-bottom: @pageActionBorder solid @colorGray12; padding: 0.5em 0; li {