From c68f7ba09f37a9329caf176d1b830b3e4124924c Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Thu, 6 Sep 2018 17:37:33 -0700 Subject: [PATCH] Issues instrumentation: issuesClicked events should always send 1 sectionNumber Erroneously in I6fd55c35b9e2ce35894259f36d1a50fb5dca5e43 for the old treatment we sent sectionNumbers for all issues in the page. This is inconsistent with the issuesSeverity field above it Add a clarifying inline comment. Bug: T203050 Change-Id: Ib1fcda0c49a162cd7aca8ee8b3221236f724e1d7 --- resources/skins.minerva.scripts/pageIssues.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/skins.minerva.scripts/pageIssues.js b/resources/skins.minerva.scripts/pageIssues.js index e2e4ef6..8dbd142 100644 --- a/resources/skins.minerva.scripts/pageIssues.js +++ b/resources/skins.minerva.scripts/pageIssues.js @@ -198,7 +198,11 @@ .map( function ( issue ) { return issue.severity; } ) ) ], - sectionNumbers: getAllIssuesSections( allIssues ) + // In the old treatment, an issuesClicked event will always be '0' + // as the old treatment is always associated with the lead section and we + // are only sending one maximum severity for all of them. + // An issuesClicked event should only ever be associated with one issue box. + sectionNumbers: [ '0' ] } ); } ); if ( $metadata.length ) {