From 2e8ea6219fa26f7febd47d658e71509ee95edb3a Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Thu, 28 Sep 2017 13:30:43 -0500 Subject: [PATCH] Update SVGs for page actions and restore locked edit icon behavior The locked edit icon will now show on protected pages. Additional changes: * userpage and userNormal was not minified. This has been fixed. Bug: T174105 Change-Id: I0ef9c4cf3ea6cd1c550023fdf99581b665b459b2 --- includes/skins/SkinMinerva.php | 3 ++- resources/skins.minerva.icons.images.scripts/userNormal.svg | 2 +- resources/skins.minerva.icons.images.scripts/watch.svg | 2 +- resources/skins.minerva.icons.images.scripts/watched.svg | 2 +- resources/skins.minerva.icons.images/edit.svg | 2 +- resources/skins.minerva.icons.images/editLocked.svg | 2 +- resources/skins.minerva.icons.images/languageSwitcher.svg | 2 +- resources/skins.minerva.userpage.icons/userpage.svg | 2 +- 8 files changed, 9 insertions(+), 8 deletions(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 2214508..d6b6e14 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -1101,11 +1101,12 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin { // Full wikitext editing is not possible via the api and hard on mobile devices. $editArgs['section'] = self::LEAD_SECTION_NUMBER; } + $userCanEdit = $title->quickUserCan( 'edit', $this->getUser() ); return [ 'id' => 'ca-edit', 'text' => '', 'itemtitle' => $this->msg( 'mobile-frontend-pageaction-edit-tooltip' ), - 'class' => MinervaUI::iconClass( 'edit-enabled', 'element' ), + 'class' => MinervaUI::iconClass( $userCanEdit ? 'edit-enabled' : 'edit', 'element' ), 'links' => [ 'edit' => [ 'href' => $title->getLocalURL( $editArgs ) diff --git a/resources/skins.minerva.icons.images.scripts/userNormal.svg b/resources/skins.minerva.icons.images.scripts/userNormal.svg index 40112c4..155377f 100644 --- a/resources/skins.minerva.icons.images.scripts/userNormal.svg +++ b/resources/skins.minerva.icons.images.scripts/userNormal.svg @@ -1 +1 @@ - + \ No newline at end of file diff --git a/resources/skins.minerva.icons.images.scripts/watch.svg b/resources/skins.minerva.icons.images.scripts/watch.svg index c2257e9..ed9baa9 100644 --- a/resources/skins.minerva.icons.images.scripts/watch.svg +++ b/resources/skins.minerva.icons.images.scripts/watch.svg @@ -1 +1 @@ -star \ No newline at end of file + \ No newline at end of file diff --git a/resources/skins.minerva.icons.images.scripts/watched.svg b/resources/skins.minerva.icons.images.scripts/watched.svg index 85303c6..321d34d 100644 --- a/resources/skins.minerva.icons.images.scripts/watched.svg +++ b/resources/skins.minerva.icons.images.scripts/watched.svg @@ -1 +1 @@ -watchlist-filled \ No newline at end of file + \ No newline at end of file diff --git a/resources/skins.minerva.icons.images/edit.svg b/resources/skins.minerva.icons.images/edit.svg index 1bb16b1..963df8f 100644 --- a/resources/skins.minerva.icons.images/edit.svg +++ b/resources/skins.minerva.icons.images/edit.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/resources/skins.minerva.icons.images/editLocked.svg b/resources/skins.minerva.icons.images/editLocked.svg index 09d66d6..34bb185 100644 --- a/resources/skins.minerva.icons.images/editLocked.svg +++ b/resources/skins.minerva.icons.images/editLocked.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/resources/skins.minerva.icons.images/languageSwitcher.svg b/resources/skins.minerva.icons.images/languageSwitcher.svg index b580443..1cd5336 100644 --- a/resources/skins.minerva.icons.images/languageSwitcher.svg +++ b/resources/skins.minerva.icons.images/languageSwitcher.svg @@ -1 +1 @@ -language switcher \ No newline at end of file + \ No newline at end of file diff --git a/resources/skins.minerva.userpage.icons/userpage.svg b/resources/skins.minerva.userpage.icons/userpage.svg index 1a86b83..161686a 100644 --- a/resources/skins.minerva.userpage.icons/userpage.svg +++ b/resources/skins.minerva.userpage.icons/userpage.svg @@ -1 +1 @@ -userpage +userpage \ No newline at end of file