golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "Hygiene: Track minerva errors count only once" 

We talked about this in standup today and given Sam's comment
in T212970#4943448 and a potential loss of data, we've considered
this a little risky and would like to revert and discuss this.

We can reapply the patch later if necessary.

This reverts commit a486bde329.

Bug: T212970
Change-Id: I0aad3937dde92bf7a46df8c1cf892bf5ce257e17
This commit is contained in:
Jdlrobson 2019-02-11 18:11:16 +00:00
parent a486bde329
commit 29bfece958
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
resources/skins.minerva.scripts/errorLogging.js
View File

@ -1,10 +1,5 @@
( function ( M, requestIdleCallback, track, config, trackSubscribe, user, experiments ) {
requestIdleCallback( function () {
/**
* Errors count in the current pageview
* @type {number}
*/
var errorsCount = 0;
/**
* Handle an error and log it if necessary
* @param {string} errorMessage to be logged
@ -35,7 +30,7 @@
isAnon: user.isAnon(),
revision: page.getRevisionId()
};
errorsCount++;
if ( isErrorLoggingEnabled ) {
track( EVENT_CLIENT_ERROR_LOG,
util.extend( {
@ -50,10 +45,8 @@
}, DEFAULT_ERROR_DATA )
);
}
}
function logErrorsCount() {
if ( errorsCount > 0 ) {
mw.track( 'counter.MediaWiki.minerva.WebClientError', errorsCount );
if ( config.get( 'wgMinervaCountErrors' ) ) {
mw.track( 'counter.MediaWiki.minerva.WebClientError', 1 );
}
}
// track RL exceptions
@ -65,9 +58,6 @@
trackSubscribe( 'global.error', function ( topic, error ) {
handleError( error.errorMessage, error.lineNumber, error.columnNumber, error.url );
} );
if ( config.get( 'wgMinervaCountErrors' ) ) {
$( window ).on( 'beforeunload', logErrorsCount );
}
} );
}(
mw.mobileFrontend,