golem
/
MinervaNeue
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove wikimedia.event.ReadingDepthSchema.enable track call 

This will send an event to a non-existent schema:
ReadingDepthSchema.enable

This was mistakedly kept for backwards compatibility.
It should have been kept for trackSubscribe not track.
The damage is done, so we should just remove this to get
error rates down to a comfortable rate again.

Bug: T207423
Change-Id: Ibb5cc2dd9b486c921aab5f8830e837f813683482
This commit is contained in:
jdlrobson 2018-10-23 11:10:53 -07:00
parent 5e7d7e918f
commit 1fd84e123f
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
resources/skins.minerva.scripts/pageIssuesLogger.js
View File

@ -49,9 +49,6 @@
function ( sectionStr ) { return parseInt( sectionStr, 10 ); }
);
// For backwards compatibility with cached WikimediaEvents code
// (remove me in a weeks time!! T207423)
mwTrack( 'wikimedia.event.ReadingDepthSchema.enable', bucketToGroup( newTreatmentEnabled ) );
// Log readingDepth schema.(ReadingDepth is guarded against multiple enables).
// See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaEvents/+/437686/
mwTrack( 'wikimedia.ReadingDepthSchema.enable', bucketToGroup( newTreatmentEnabled ) );