From 118f4df82811dc58012addd9f57a5fc60bd3f46d Mon Sep 17 00:00:00 2001 From: Stephen Niedzielski Date: Thu, 7 Feb 2019 10:54:56 -0700 Subject: [PATCH] Hygiene: replace deepEqual tests with propEqual Replace QUnit deepEqual() assertions with propEqual(). The former is a recursive == check, the latter is a recursive === check which seems preferable. find tests -name \*.js| xargs -rd\\n sed -ri 's%deepEqual%propEqual%g' Change-Id: I977244d24c47072cc62b7d9fc797505a5f39aa54 --- tests/qunit/skins.minerva.scripts/pageIssues.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qunit/skins.minerva.scripts/pageIssues.test.js b/tests/qunit/skins.minerva.scripts/pageIssues.test.js index 63a1dc8..213570e 100644 --- a/tests/qunit/skins.minerva.scripts/pageIssues.test.js +++ b/tests/qunit/skins.minerva.scripts/pageIssues.test.js @@ -97,22 +97,22 @@ MEDIUM_ISSUE ] }; - assert.deepEqual( + assert.propEqual( getAllIssuesSections( allIssuesOldTreatment ), [ '0', '0', '0' ], 'section numbers correctly extracted from old treatment' ); - assert.deepEqual( + assert.propEqual( getAllIssuesSections( allIssuesNewTreatment ), [ '0', '0', '0', '1' ], 'section numbers correctly extracted from new treatment' ); - assert.deepEqual( + assert.propEqual( getAllIssuesSections( multipleIssues ), [ '0' ], 'multiple issues are packed into one entry since there is one box' ); - assert.deepEqual( + assert.propEqual( getAllIssuesSections( multipleIssuesWithDeletion ), [ '0', '0' ], 'while multiple issues are grouped, non-multiple issues are still reported'