From 0ee78ce0cb75d9097755a66c34ec9bbec4209fd9 Mon Sep 17 00:00:00 2001
From: jdlrobson <jdlrobson@gmail.com>
Date: Tue, 5 Sep 2017 17:19:05 -0400
Subject: [PATCH] EventLogging modules should be soft dependencies

Change-Id: Ibc546a89b11360769c9c50dc52cb9b7b5e433100
---
 resources/skins.minerva.editor/init.js       | 17 +++++++++++------
 resources/skins.minerva.mainMenu/MainMenu.js |  2 ++
 skin.json                                    |  6 ++----
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/resources/skins.minerva.editor/init.js b/resources/skins.minerva.editor/init.js
index 862180b..c71dd2f 100644
--- a/resources/skins.minerva.editor/init.js
+++ b/resources/skins.minerva.editor/init.js
@@ -168,14 +168,19 @@
 			 * @method
 			 */
 			function logInit( editor ) {
-				mw.track( 'mf.schemaEdit', {
-					action: 'init',
-					type: 'section',
-					mechanism: initMechanism,
-					editor: editor,
-					editingSessionId: editorOptions.sessionId
+				// If MobileFrontend is not available this will not be possible so
+				// check first.
+				mw.loader.using( 'mobile.loggingSchemas.edit' ).done( function () {
+					mw.track( 'mf.schemaEdit', {
+						action: 'init',
+						type: 'section',
+						mechanism: initMechanism,
+						editor: editor,
+						editingSessionId: editorOptions.sessionId
+					} );
 				} );
 			}
+
 			/**
 			 * Load source editor
 			 * @private
diff --git a/resources/skins.minerva.mainMenu/MainMenu.js b/resources/skins.minerva.mainMenu/MainMenu.js
index 4b51e40..e957cf3 100644
--- a/resources/skins.minerva.mainMenu/MainMenu.js
+++ b/resources/skins.minerva.mainMenu/MainMenu.js
@@ -36,6 +36,8 @@
 		 * attributes on elements.
 		 */
 		enableLogging: function () {
+			// Load the EventLogging module inside MobileFrontend if available
+			mw.loader.using( 'mobile.loggingSchemas.mobileWebMainMenuClickTracking' );
 			this.$( 'a' ).on( 'click', function () {
 				var $link = $( this ),
 					eventName = $link.data( 'event-name' );
diff --git a/skin.json b/skin.json
index 47a89cb..319e415 100644
--- a/skin.json
+++ b/skin.json
@@ -233,8 +233,7 @@
 			"dependencies": [
 				"skins.minerva.mainMenu.icons",
 				"skins.minerva.mainMenu.styles",
-				"mobile.startup",
-				"mobile.loggingSchemas.mobileWebMainMenuClickTracking"
+				"mobile.startup"
 			],
 			"position": "bottom",
 			"templates": {
@@ -360,8 +359,7 @@
 				"mediawiki.ui.input",
 				"mobile.startup",
 				"skins.minerva.toggling",
-				"mediawiki.jqueryMsg",
-				"mobile.loggingSchemas.edit"
+				"mediawiki.jqueryMsg"
 			],
 			"messages": {
 				"0": "mobile-frontend-editor-disabled",