From 0a2099930b5a956f8cd87c072e67d080bbea37e5 Mon Sep 17 00:00:00 2001 From: Stephen Niedzielski Date: Tue, 6 Aug 2019 09:28:47 -0600 Subject: [PATCH] [dev] add return type to SkinMinerva.getSkinStyles() Specify the return type for getSkinStyles() and add some documentation. Change-Id: I06a77d3015ed77c2aa38d31fe8422fcb8bcaf9fd --- includes/skins/SkinMinerva.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 7752a44..bd102b3 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -897,10 +897,15 @@ class SkinMinerva extends SkinTemplate { } /** - * Get the needed styles for this skin + * Provide styles required to present the server rendered page in this skin. Additional styles + * may be loaded dynamically by the client. + * + * Any styles returned by this method are loaded on the critical rendering path as linked + * stylesheets. I.e., they are required to load on the client before first paint. + * * @return array */ - protected function getSkinStyles() { + protected function getSkinStyles(): array { $title = $this->getTitle(); $styles = [ 'skins.minerva.base.styles',