diff --git a/resources/skins.minerva.scripts/init.js b/resources/skins.minerva.scripts/init.js index 3106a1d..39a3ccf 100644 --- a/resources/skins.minerva.scripts/init.js +++ b/resources/skins.minerva.scripts/init.js @@ -3,6 +3,7 @@ toast = M.require( 'mobile.startup/toast' ), time = M.require( 'mobile.startup/time' ), skin = M.require( 'mobile.init/skin' ), + subscribeToWikimediaEvents = M.require( 'skins.minerva.scripts/subscribeToWikimediaEvents' ), issues = M.require( 'skins.minerva.scripts/pageIssues' ), DownloadIcon = M.require( 'skins.minerva.scripts/DownloadIcon' ), browser = M.require( 'mobile.startup/Browser' ).getSingleton(), @@ -289,6 +290,9 @@ if ( !page.isMissing ) { issues.init( overlayManager, page ); } + // it's important this runs after issues.init - at which point the A/B test + // has been initialised, and we can turn on ReadingDepth safely. + subscribeToWikimediaEvents(); } ); M.define( 'skins.minerva.scripts/overlayManager', overlayManager ); diff --git a/resources/skins.minerva.scripts/initLogging.js b/resources/skins.minerva.scripts/initLogging.js index e7dfc5b..c7599af 100644 --- a/resources/skins.minerva.scripts/initLogging.js +++ b/resources/skins.minerva.scripts/initLogging.js @@ -3,7 +3,16 @@ ( function ( M, $ ) { var mainMenu = M.require( 'skins.minerva.scripts.top/mainMenu' ); + /** + * Enable WikimediaEvents including ReadingDepth schema + */ + function subscribeToWikimediaEvents() { + mw.loader.using( 'ext.wikimediaEvents' ); + } + $( function () { mainMenu.enableLogging(); } ); + + M.define( 'skins.minerva.scripts/subscribeToWikimediaEvents', subscribeToWikimediaEvents ); }( mw.mobileFrontend, jQuery ) ); diff --git a/skin.json b/skin.json index 453ca23..13b129e 100644 --- a/skin.json +++ b/skin.json @@ -424,6 +424,7 @@ }, "scripts": [ "resources/skins.minerva.scripts/errorLogging.js", + "resources/skins.minerva.scripts/initLogging.js", "resources/skins.minerva.scripts/preInit.js", "resources/skins.minerva.scripts/DownloadIcon.js", "resources/skins.minerva.scripts/pageIssuesLogger.js", @@ -432,7 +433,6 @@ "resources/skins.minerva.scripts/PageIssuesOverlay.js", "resources/skins.minerva.scripts/pageIssues.js", "resources/skins.minerva.scripts/init.js", - "resources/skins.minerva.scripts/initLogging.js", "resources/skins.minerva.scripts/mobileRedirect.js", "resources/skins.minerva.scripts/search.js", "resources/skins.minerva.scripts/references.js"