golem
/
Math
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix error in checking logic 

Tex validation should be skipped if checking is disabled.
Consequently if 'disable tex filter' is set to 'never' it's a double
negation and tex should always be checked.
If 'disable tex filter' is set to always, never check tex.

Change-Id: Ic6fda8016838eae03a0ed36e3d8d4f35423ba8b1
This commit is contained in:
physikerwelt 2015-12-03 08:22:34 +01:00
parent 9452a58563
commit c66a85f143
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MathRenderer.php
View File

@ -563,7 +563,7 @@ abstract class MathRenderer {
* @return bool
*/
public function checkTex() {
if ( $this->texSecure || self::getDisableTexFilter() == 'never' ) {
if ( $this->texSecure || self::getDisableTexFilter() == 'always' ) {
// equation was already checked or checking is disabled
return true;
} else {

8
tests/MathRendererTest.php
View File

@ -64,8 +64,8 @@ class MathRendererTest extends MediaWikiTestCase {
}
public function testCheckingAlways() {
$this->setMwGlobals( "wgMathDisableTexFilter", 'always' );
public function testDisableCheckingAlways() {
$this->setMwGlobals( "wgMathDisableTexFilter", 'never' );
$renderer =
$this->getMockBuilder( 'MathRenderer' )->setMethods( array(
'render',
@ -83,8 +83,8 @@ class MathRendererTest extends MediaWikiTestCase {
}
public function testCheckingNever() {
$this->setMwGlobals( "wgMathDisableTexFilter", 'never' );
public function testDisableCheckingNever() {
$this->setMwGlobals( "wgMathDisableTexFilter", 'always' );
$renderer =
$this->getMockBuilder( 'MathRenderer' )->setMethods( array(
'render',