From c3ebc549943f06e4ef1149d2701fb43de077a687 Mon Sep 17 00:00:00 2001 From: Marko Obrovac Date: Mon, 14 Dec 2015 23:58:08 +0100 Subject: [PATCH] Minor: rename checkTex() to checkTeX() Change-Id: I9b1860562b2f4f2112b68c0c3d6f0390f0405fbe --- Math.hooks.php | 2 +- MathRenderer.php | 2 +- MathTexvc.php | 2 +- tests/MathRendererTest.php | 14 +++++++------- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Math.hooks.php b/Math.hooks.php index 5b6220f..b54684a 100644 --- a/Math.hooks.php +++ b/Math.hooks.php @@ -194,7 +194,7 @@ class MathHooks { $renderer = MathRenderer::getRenderer( $content, $attributes, $mode ); - $checkResult = $renderer->checkTex(); + $checkResult = $renderer->checkTeX(); if ( $checkResult !== true ) { // Returns the error message diff --git a/MathRenderer.php b/MathRenderer.php index fa7c4c9..ddcbc12 100644 --- a/MathRenderer.php +++ b/MathRenderer.php @@ -562,7 +562,7 @@ abstract class MathRenderer { * @global $wgMathDisableTexFilter * @return bool */ - public function checkTex() { + public function checkTeX() { if ( $this->texSecure || self::getDisableTexFilter() == 'always' ) { // equation was already checked or checking is disabled return true; diff --git a/MathTexvc.php b/MathTexvc.php index fae0576..3233858 100644 --- a/MathTexvc.php +++ b/MathTexvc.php @@ -474,7 +474,7 @@ class MathTexvc extends MathRenderer { * texvccheck was derived from texvc. * @return bool */ - public function checkTex() { + public function checkTeX() { return true; } diff --git a/tests/MathRendererTest.php b/tests/MathRendererTest.php index 4ab6e68..68f4b5d 100644 --- a/tests/MathRendererTest.php +++ b/tests/MathRendererTest.php @@ -96,9 +96,9 @@ class MathRendererTest extends MediaWikiTestCase { $renderer->expects( $this->never() )->method( 'readFromDatabase' ); $renderer->expects( $this->once() )->method( 'setTex' )->with( self::TEXVCCHECK_OUTPUT ); - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); // now setTex sould not be called again - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); } @@ -115,7 +115,7 @@ class MathRendererTest extends MediaWikiTestCase { $renderer->expects( $this->never() )->method( 'readFromDatabase' ); $renderer->expects( $this->never() )->method( 'setTex' ); - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); } public function testCheckingNewUnknown() { @@ -132,9 +132,9 @@ class MathRendererTest extends MediaWikiTestCase { ->will( $this->returnValue( false ) ); $renderer->expects( $this->once() )->method( 'setTex' )->with( self::TEXVCCHECK_OUTPUT ); - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); // now setTex sould not be called again - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); } public function testCheckingNewKnown() { @@ -151,9 +151,9 @@ class MathRendererTest extends MediaWikiTestCase { ->will( $this->returnValue( true ) ); $renderer->expects( $this->never() )->method( 'setTex' ); - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); // we don't mark a object as checked even though we rely on the database cache // so readFromDatabase will be called again - $this->assertEquals( $renderer->checkTex(), true ); + $this->assertEquals( $renderer->checkTeX(), true ); } }