From 3f0398e0316c592ca396290dd4152a5fb33a0978 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 13 Apr 2018 15:32:05 +0200 Subject: [PATCH] Remove non-helpful comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Documenting protected members as protected members is not really helpful. One can see this by looking at the code. Same for documenting a variable named "$html…" as "HTML". This does not add anything. Change-Id: I72364b6857166d77b9c85aa884cd139dc163c6bb --- MathChemSymbolsDataModule.php | 4 ---- MathFormatter.php | 4 ++-- MathMathSymbolsDataModule.php | 4 ---- MathRenderer.php | 2 -- tests/MathMLRdfBuilderTest.php | 1 - 5 files changed, 2 insertions(+), 13 deletions(-) diff --git a/MathChemSymbolsDataModule.php b/MathChemSymbolsDataModule.php index 60735f2..9e8baa8 100644 --- a/MathChemSymbolsDataModule.php +++ b/MathChemSymbolsDataModule.php @@ -10,13 +10,9 @@ class MathChemSymbolsDataModule extends ResourceLoaderModule { - /* Protected Members */ - protected $origin = self::ORIGIN_USER_SITEWIDE; protected $targets = [ 'desktop', 'mobile' ]; - /* Methods */ - public function getScript( ResourceLoaderContext $context ) { return 've.ui.MWChemDialog.static.setSymbols(' . file_get_contents( __DIR__ . '/modules/ve-math/chemSymbols.json' ) . diff --git a/MathFormatter.php b/MathFormatter.php index c21a1fc..5d3569e 100644 --- a/MathFormatter.php +++ b/MathFormatter.php @@ -80,8 +80,8 @@ class MathFormatter implements ValueFormatter { /** * Constructs a detailed HTML rendering for use in diff views. * - * @param string $valueHtml HTML - * @param string $tex TeX + * @param string $valueHtml + * @param string $tex * * @return string HTML */ diff --git a/MathMathSymbolsDataModule.php b/MathMathSymbolsDataModule.php index bcb5f3e..e1899aa 100644 --- a/MathMathSymbolsDataModule.php +++ b/MathMathSymbolsDataModule.php @@ -10,13 +10,9 @@ class MathMathSymbolsDataModule extends ResourceLoaderModule { - /* Protected Members */ - protected $origin = self::ORIGIN_USER_SITEWIDE; protected $targets = [ 'desktop', 'mobile' ]; - /* Methods */ - public function getScript( ResourceLoaderContext $context ) { return 've.ui.MWMathDialog.static.setSymbols(' . file_get_contents( __DIR__ . '/modules/ve-math/mathSymbols.json' ) . diff --git a/MathRenderer.php b/MathRenderer.php index 014d320..6107eae 100644 --- a/MathRenderer.php +++ b/MathRenderer.php @@ -121,7 +121,6 @@ abstract class MathRenderer { } /** - * * @param string $md5 * @return MathRenderer the MathRenderer generated from md5 */ @@ -555,7 +554,6 @@ abstract class MathRenderer { } /** - * * @param string $mathStyle ('inlineDisplaystyle'|'display'|'inline') */ public function setMathStyle( $mathStyle = 'display' ) { diff --git a/tests/MathMLRdfBuilderTest.php b/tests/MathMLRdfBuilderTest.php index bfde231..bf75ace 100644 --- a/tests/MathMLRdfBuilderTest.php +++ b/tests/MathMLRdfBuilderTest.php @@ -34,7 +34,6 @@ class MathMLRdfBuilderTest extends MediaWikiTestCase { } /** - * * @param string $test * @return string */