From 1c79c4a2eca5eefefd3fbdd3f2e41406a3c47ed3 Mon Sep 17 00:00:00 2001
From: Kunal Mehta <legoktm@member.fsf.org>
Date: Sat, 9 Mar 2019 18:34:56 -0800
Subject: [PATCH] Avoid use of func_get_args()

Change-Id: I2b0f50e00cd2c7ba744c75f623b0349930cdfd62
---
 src/MathRenderer.php | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/MathRenderer.php b/src/MathRenderer.php
index 16a068f..6eeb943 100644
--- a/src/MathRenderer.php
+++ b/src/MathRenderer.php
@@ -205,15 +205,13 @@ abstract class MathRenderer {
 	 * Returns an internationalized HTML error string
 	 *
 	 * @param string $msg message key for specific error
-	 * @note param \Varargs $parameters (optional) zero
-	 * or more message parameters for specific error
+	 * @param string ...$parameters zero or more message
+	 *  parameters for specific error
 	 *
 	 * @return string HTML error string
 	 */
-	public function getError( $msg /*, ... */ ) {
+	public function getError( $msg, ...$parameters ) {
 		$mf = wfMessage( 'math_failure' )->inContentLanguage()->escaped();
-		$parameters = func_get_args();
-		array_shift( $parameters );
 		$errmsg = wfMessage( $msg, $parameters )->inContentLanguage()->escaped();
 		$source = htmlspecialchars( str_replace( "\n", ' ', $this->tex ) );
 		return "<strong class='error texerror'>$mf ($errmsg): $source</strong>\n";